PR: Fix syntax in test_namespacebrowser.py for Python 3.8 and 3.9
#21333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `with (..., ...)` syntax was introduced in Python 3.10. Before, multiple context managers were possible but it had to be written without parentheses. Thus, this commit introduces backslashes so that the code works in Python 3.8 and 3.9.
ccordoba12
approved these changes
Sep 13, 2023
There was a problem hiding this comment.
Thanks @jitseniesen! I can confirm this fix allows our test suite to run on those Python versions (before it was not even starting due to a syntax error).
I'm going to merge this one and fix the failing tests in a follow-up PR.
ccordoba12
changed the title
test_namespacebrowser.py for Python 3.8 and 3.9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
This is a follow-up for PR #21235 which included a test that does not work under Python 3.8, as noted in #21235 (comment). This was not picked up by the automatic tests because of #21322.
Specifically, the
with (..., ...)syntax was introduced in Python 3.10. Before, multiple context managers were possible but it had to be written without parentheses. Thus, this PR replace the parentheses with backslashes so that the test code works in Python 3.8 and 3.9.Affirmation
By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.
I certify the above statement is true and correct: Jitse Niesen