Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Fix some failing tests #21323

Merged
merged 3 commits into from
Sep 11, 2023
Merged

PR: Fix some failing tests #21323

merged 3 commits into from
Sep 11, 2023

Conversation

impact27
Copy link
Contributor

@impact27 impact27 commented Sep 10, 2023

Description of Changes

  • Wrote at least one-line docstrings (for any new functions)
  • Added unit test(s) covering the changes (if testable)
  • Included a screenshot or animation (if affecting the UI, see Licecap)

Issue(s) Resolved

Part of #21322

Spyder-kernels: spyder-ide/spyder-kernels#467

Affirmation

By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct:

@impact27 impact27 changed the title WIP: PR: fix tests PR: fix tests Sep 11, 2023
@ccordoba12 ccordoba12 added this to the v6.0alpha3 milestone Sep 11, 2023
@ccordoba12 ccordoba12 changed the title PR: fix tests PR: Fix some failing tests Sep 11, 2023
@ccordoba12
Copy link
Member

@impact27, I'll rework your PR a bit to include the one you did in Spyder-kernels.

Quentin Peter and others added 3 commits September 11, 2023 10:51
…r-kernels.git --branch=master --update --force external-deps/spyder-kernels

subrepo:
  subdir:   "external-deps/spyder-kernels"
  merged:   "d7fe712f64"
upstream:
  origin:   "https://github.com/spyder-ide/spyder-kernels.git"
  branch:   "master"
  commit:   "d7fe712f64"
git-subrepo:
  version:  "0.4.3"
  origin:   "https://github.com/ingydotnet/git-subrepo"
  commit:   "2f68596"
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @impact27!

@ccordoba12 ccordoba12 merged commit dbe7eed into spyder-ide:master Sep 11, 2023
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants