Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Remove installers workflow step validation for spyder conda package build to be done only on PRs (CI) #21300

Merged

Conversation

dalthviz
Copy link
Member

@dalthviz dalthviz commented Sep 1, 2023

Description of Changes

As part of the Spyder 6alpha2 release I did the release candidate step and tried to generate the installers, but seems like the manual worflow dispatch fails due to the spyder conda package build step being skipped (seems like it was skipped if the workflow is not being run from a PR). Not totally sure if this is the correct approach but opening a PR just in case and to discuss if something else needs to be done @ccordoba12 @mrclary

Affirmation

By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct: dalthviz

@dalthviz dalthviz added this to the v6.0alpha2 milestone Sep 1, 2023
@dalthviz dalthviz self-assigned this Sep 1, 2023
@ccordoba12
Copy link
Member

I'll let @mrclary review this one because I'm not sure if this is the right approach.

@mrclary
Copy link
Contributor

mrclary commented Sep 1, 2023

Okay, I'll look at it this weekend. I'm away from my computer right now.

Copy link
Contributor

@mrclary mrclary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dalthviz, thank you for catching this. Yes, your proposed changes are correct. This was an error on my part when refactoring the workflows for caching. The spyder conda package should be built for all workflow conditions.

@mrclary mrclary merged commit f7ff44d into spyder-ide:master Sep 2, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants