PR: Fix error after changes to Plugins page (Preferences) #21236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ccordoba12
changed the title
ccordoba12
changed the title
ccordoba12
reviewed
Aug 9, 2023
There was a problem hiding this comment.
Thanks @rear1019 for your help with this!
There's one small thing missing though: you need to do the same for external plugins as well, which is a some lines below the change you did (specifically in line 89).
The Plugins section in the preferences dialog allows to enable/disable plugins. After making changes and pressing OK or Apply in the preferences dialog, an error occurred. The error occurs because of a change of the return type of SpyderConfigPage.create_checkbox() (see PR20926 [1]). [1] spyder-ide#20926
rear1019
force-pushed
the
fix_preferences_plugins
branch
from
a1c8dd0
to
ab3e00a
Compare
Done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commit message for details
Description of Changes
Affirmation
By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.
I certify the above statement is true and correct:
rear1019