PR: Automatically launch Spyder after installation (Installers)

[mrclary]

Automatically launch Spyder after install

[ccordoba12]

@mrclary, I pushed directly to your branch a commit to improve the message we show on Linux when the installer finishes. This was bothering me a bit the last times I tested the installer and it was not easy to leave a suggestion for it here.

[ccordoba12]

@mrclary, one small comment from me, the rest looks good.

I also forgot to mention that if you have comments or suggestions about the changes I pushed to your branch, please let me know about them.

[dalthviz]

Thanks @mrclary ! Checked locally on Windows and Spyder launches automatically! 👍

However, if understand correctly. with this Spyder will always open after installation? There is no possibility to have a user confirmation before launch Spyder, right? Also, seems like the installer window is still present after Spyder opens and you have to click next to see the last installer page and close it:

Other than those pointers, which probably are caused do to the way constructor post install script works on Windows so there is not much we can do here about that, this LGTM 👍

[mrclary]

@dalthviz, thanks for reviewing this PR.

However, if understand correctly. with this Spyder will always open after installation? There is no possibility to have a user confirmation before launch Spyder, right?

Correct. I think this could be fixed for Windows if we used an nsis template. I don't think constructor will ever adopt an application launcher mechanism so I don't think this will be a possibility for macOS and Linux, unless we could patch that into constructor ourselves.

Also, seems like the installer window is still present after Spyder opens and you have to click next to see the last installer page and close it

That is correct. I may be able to devise a solution for all platforms to delay launching Spyder until the installer is closed. 👀

[mrclary]

Also, seems like the installer window is still present after Spyder opens and you have to click next to see the last installer page and close it

That is correct. I may be able to devise a solution for all platforms to delay launching Spyder until the installer is closed. 👀

@dalthviz, I just pushed up another commit that may resolve this issue. Another process is started that waits for the graphical installer to exit before starting Spyder.

[ccordoba12]

I found a bug while testing this (related to PR #20933) and I solve it on PR #21092.

Besides that, now Spyder launches after installation (which is great!), but the spyder bash alias is broken with this error:

$ spyder
gtk-launch: missing application name
Try "gtk-launch --help" for more information.

I'd prefer to not use gtk-launch to launch Spyder in the command line, especially to pass cli arguments to it. So, I think the previous implementation of that command was fine.

uninstall-spyder is also broken. It simply reports Uninstall aborted at the end.

[mrclary]

I found a bug while testing this (related to PR #20933) and I solve it on PR #21092.

I just noticed that. Strange that it doesn't throw that error when bootstrapping...

Besides that, now Spyder launches after installation (which is great!), but the spyder bash alias is broken with this error:

$ spyder
gtk-launch: missing application name
Try "gtk-launch --help" for more information.

I'd prefer to not use gtk-launch to launch Spyder in the command line, especially to pass cli arguments to it. So, I think the previous implementation of that command was fine.

Ohh, that's right. Will revert.

uninstall-spyder is also broken. It simply reports Uninstall aborted at the end.

I'll look at these errors. Thanks for investigating this @ccordoba12 😄

[ccordoba12]

I just noticed that. Strange that it doesn't throw that error when bootstrapping...

I think that's because updates are not run on DEV mode.

[dalthviz]

I just pushed up another commit that may resolve this issue. Another process is started that waits for the graphical installer to exit before starting Spyder.

Awesome! However, checking again, seems like a cmd shows up in the task bar and you can click on it (I guess is related with the waiting process?). Is there something that could be done to prevent that cmd from showing/being shown in the task bar?

Anyhow, I think is nice that now Spyder launches after the installer window finishes/is closed 👍

[mrclary]

@ccordoba12 @dalthviz, I think all the issues have been worked out now. Additionally, Spyder should delay starting until the graphical installer exits (macOS and Windows).

[mrclary]

However, checking again, seems like a cmd shows up in the task bar and you can click on it (I guess is related with the waiting process?). Is there something that could be done to prevent that cmd from showing/being shown in the task bar?

That is correct; it is the waiting process. It is not possible to hide the cmd.exe window, only minimize it under these circumstances. However, I could try using a powershell process instead; maybe that will allow the hidden window... 👀

[ccordoba12]

Last, small suggestion from me, the rest is working as expected. Thanks @mrclary!

[mrclary]

@dalthviz, so switching to powershell did allow me to eliminate the minimized window. However, there is still a temporary "flash" of the powershell window. This is the same issue @jaimergp and I ran into with the lnk target and menuinst. I think it may be either a bug in powershell or I just don't know the right way to work it 😬. Nevertheless, I think it may be an improvement over a minimized window. What do you think?

[dalthviz]

Nevertheless, I think it may be an improvement over a minimized window. What do you think?

Checked locally and for sure is an improvement! Even if it shows for a moment, I would say is better since users will not be able to interact with a cmd 👍

[ccordoba12]

Works like a charm for me now, thanks @mrclary!

[ccordoba12]

@dalthviz, are you good to merge now?

[dalthviz]

Thanks @mrclary !