Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Move CONF usage for bookmarks logic and use SpyderConfiguratorAccessor class in Editor widgets (Editor) #20825

Merged
merged 5 commits into from
Apr 20, 2023

Conversation

dalthviz
Copy link
Member

Description of Changes

Replace direct CONF usage in the Editor related widgets for methods inherited from the SpyderConfiguratorAccessor class

Affirmation

By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct: dalthviz

@dalthviz dalthviz added this to the v6.0alpha1 milestone Apr 14, 2023
@dalthviz dalthviz self-assigned this Apr 14, 2023
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dalthviz, some small suggestions and a question for you, otherwise looks good to me.

spyder/plugins/editor/plugin.py Outdated Show resolved Hide resolved
spyder/plugins/editor/utils/bookmarks.py Outdated Show resolved Hide resolved
spyder/plugins/editor/widgets/base.py Outdated Show resolved Hide resolved
spyder/plugins/editor/widgets/editor.py Show resolved Hide resolved
spyder/plugins/editor/widgets/editor.py Outdated Show resolved Hide resolved
spyder/plugins/editor/widgets/editor.py Outdated Show resolved Hide resolved
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me now, thanks @dalthviz!

@ccordoba12 ccordoba12 merged commit 11dee3c into spyder-ide:master Apr 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants