-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR: Fix issue where replace all did not respect whole words filter #20497
PR: Fix issue where replace all did not respect whole words filter #20497
Conversation
2b33bd3
to
50ea8bf
Compare
@mrclary, I changed the base branch of your PR to |
I'll rebase my branch off master as well. |
50ea8bf
to
cea807c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @mrclary for your work on this!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One last stylistic change that I missed before, then this should be ready for me.
@impact27, do you have something else to say about this one? |
Remove superfluous string length test.
Co-authored-by: Carlos Cordoba <ccordoba12@gmail.com>
Co-authored-by: Carlos Cordoba <ccordoba12@gmail.com>
2477eb1
to
5431c31
Compare
Looks good to me, I would just add a comment explaining |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @mrclary!
Description of Changes
Issue(s) Resolved
Fixes #20403