-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR: Update conda-based installers #20471
Conversation
97c95a5
to
aa96e82
Compare
a64a0d2
to
445772b
Compare
c475fb5
to
5902fea
Compare
@dalthviz @ccordoba12 I'm having trouble getting the Windows test to work properly; perhaps you guys have some insight. The following should execute the $ cmd.exe /C start /wait "<path to exe>" /S I've successfully tested on my Windows VM (with bash shell), but can't get it working in CI. From the logs it appears that |
I can see that you're not using a Bash shell to run the installer tests on Windows (i.e. there's no |
Hmm. For the |
Ok, sorry for the noise. |
No worries, thanks for looking at it. |
c0117ef
to
608175d
Compare
* Resolves 'set-output' deprecation warnings * actions/upload-release-asset is no longer maintained (last update 2yrs ago)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks @mrclary!
Description of Changes
StartupWMClass
to Linux desktop file. This obviates the need to change the name of the desktop file in the post-install script.