Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Update conda-based installers #20471

Merged
merged 4 commits into from
Feb 24, 2023
Merged

Conversation

mrclary
Copy link
Contributor

@mrclary mrclary commented Feb 3, 2023

Description of Changes

  • Added StartupWMClass to Linux desktop file. This obviates the need to change the name of the desktop file in the post-install script.
  • Minor CI workflow updates

@mrclary mrclary marked this pull request as draft February 3, 2023 19:38
@mrclary mrclary force-pushed the update-cbi branch 6 times, most recently from 97c95a5 to aa96e82 Compare February 10, 2023 16:47
@mrclary mrclary force-pushed the update-cbi branch 2 times, most recently from a64a0d2 to 445772b Compare February 11, 2023 22:28
@ccordoba12 ccordoba12 added this to the v6.0alpha1 milestone Feb 11, 2023
@mrclary mrclary changed the base branch from 5.x to master February 17, 2023 18:12
@mrclary mrclary force-pushed the update-cbi branch 4 times, most recently from c475fb5 to 5902fea Compare February 17, 2023 22:11
@mrclary
Copy link
Contributor Author

mrclary commented Feb 18, 2023

@dalthviz @ccordoba12 I'm having trouble getting the Windows test to work properly; perhaps you guys have some insight.

The following should execute the exe installer from the bash command line in silent mode:

$ cmd.exe /C start /wait "<path to exe>" /S

I've successfully tested on my Windows VM (with bash shell), but can't get it working in CI. From the logs it appears that cmd.exe is executed but the executable path is not resolved properly: the cmd.exe banner is printed but the installer does not run.

@ccordoba12
Copy link
Member

The following should execute the exe installer from the bash command line in silent mode

I can see that you're not using a Bash shell to run the installer tests on Windows (i.e. there's no shell: bash in the Test Installer Application step). And I think the default shell used by Github Actions on Windows is cmd.

@mrclary
Copy link
Contributor Author

mrclary commented Feb 20, 2023

I can see that you're not using a Bash shell to run the installer tests on Windows (i.e. there's no shell: bash in the Test Installer Application step). And I think the default shell used by Github Actions on Windows is cmd.

Hmm. For the build-installers job I am using a default shell defaults: run: shell: bash -l {0}, and the Test Application Bundle step is a bash script. And in the same step I've confirmed [[ -e "$PKG_FILE" ]] && echo "Installer exists" || echo "Installer does not exist" successfully reports that the $PKG_FILE exists while running in Windows.

@ccordoba12
Copy link
Member

Ok, sorry for the noise.

@mrclary
Copy link
Contributor Author

mrclary commented Feb 20, 2023

Ok, sorry for the noise.

No worries, thanks for looking at it.

@mrclary mrclary mentioned this pull request Feb 20, 2023
1 task
@mrclary mrclary force-pushed the update-cbi branch 5 times, most recently from c0117ef to 608175d Compare February 22, 2023 06:57
* Resolves 'set-output' deprecation warnings
* actions/upload-release-asset is no longer maintained (last update 2yrs ago)
@mrclary mrclary marked this pull request as ready for review February 24, 2023 03:27
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks @mrclary!

@ccordoba12 ccordoba12 merged commit 7e68969 into spyder-ide:master Feb 24, 2023
@mrclary mrclary deleted the update-cbi branch February 24, 2023 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants