Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR: Update Variable Explorer from the kernel #19842

Merged
merged 11 commits into from
Feb 11, 2023
Merged

PR: Update Variable Explorer from the kernel #19842

merged 11 commits into from
Feb 11, 2023

Conversation

impact27
Copy link
Contributor

@impact27 impact27 commented Oct 15, 2022 •
edited
Loading

Description of Changes

When several clients are connected to a kernel, only the client that sent the execute requests has his variable explorer updated. To solve this, the variable explorer is updated from the kernel instead.

goes with spyder-ide/spyder-kernels#421

  • Wrote at least one-line docstrings (for any new functions)
  • Added unit test(s) covering the changes (if testable)
  • Included a screenshot or animation (if affecting the UI, see Licecap)

Issue(s) Resolved

Fixes #

Affirmation

By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct:

@impact27 impact27 mentioned this pull request Oct 15, 2022
Merged
@impact27 impact27 force-pushed the update_state branch 6 times, most recently from fec1f83 to 7a2ba46 Compare October 19, 2022 09:15
Quentin Peter added 2 commits November 6, 2022 00:48
handle state
0660b89
git subrepo clone (merge) --branch=update_state --force https://githu…
864953e 
…b.com/impact27/spyder-kernels.git external-deps/spyder-kernels

subrepo:
  subdir:   "external-deps/spyder-kernels"
  merged:   "293c47f12"
upstream:
  origin:   "https://github.com/impact27/spyder-kernels.git"
  branch:   "update_state"
  commit:   "293c47f12"
git-subrepo:
  version:  "0.4.5"
  origin:   "https://github.com/ingydotnet/git-subrepo"
  commit:   "aa416e4"
@impact27 impact27 changed the title [WIP] PR: Update variable explorer from the kernel PR: Update variable explorer from the kernel Nov 5, 2022
@ccordoba12 ccordoba12 added this to the v6.0alpha1 milestone Feb 10, 2023
ccordoba12
ccordoba12 reviewed Feb 10, 2023
View reviewed changes
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @impact27 for this improvement! My review is mostly meant to improve your code's readability, but the implementation looks good to me.

spyder/plugins/ipythonconsole/widgets/shell.py Outdated Show resolved Hide resolved
spyder/plugins/ipythonconsole/widgets/shell.py Outdated Show resolved Hide resolved
spyder/plugins/ipythonconsole/widgets/shell.py Outdated Show resolved Hide resolved
spyder/plugins/ipythonconsole/widgets/shell.py Show resolved Hide resolved
spyder/plugins/ipythonconsole/widgets/shell.py Outdated Show resolved Hide resolved
spyder/plugins/variableexplorer/widgets/main_widget.py Outdated Show resolved Hide resolved
spyder/plugins/variableexplorer/widgets/main_widget.py Outdated Show resolved Hide resolved
spyder/plugins/variableexplorer/widgets/namespacebrowser.py Outdated Show resolved Hide resolved
spyder/plugins/variableexplorer/widgets/namespacebrowser.py Outdated Show resolved Hide resolved
spyder/plugins/variableexplorer/widgets/namespacebrowser.py Outdated Show resolved Hide resolved
impact27 and others added 3 commits February 10, 2023 16:21
@impact27 @ccordoba12
Apply suggestions from code review
4f08204 
Co-authored-by: Carlos Cordoba <ccordoba12@gmail.com>
Merge remote-tracking branch 'upstream/master' into update_state
b340811
git subrepo clone --branch=update_state --force https://github.com/im…
6150e00 
…pact27/spyder-kernels.git external-deps/spyder-kernels

subrepo:
  subdir:   "external-deps/spyder-kernels"
  merged:   "7c06d58c3"
upstream:
  origin:   "https://github.com/impact27/spyder-kernels.git"
  branch:   "update_state"
  commit:   "7c06d58c3"
git-subrepo:
  version:  "0.4.5"
  origin:   "https://github.com/ingydotnet/git-subrepo"
  commit:   "aa416e4"
@ccordoba12 ccordoba12 changed the title PR: Update variable explorer from the kernel PR: Update Variable Explorer from the kernel Feb 10, 2023
Quentin Peter added 3 commits February 11, 2023 08:26
fix review
8d1b18b
Merge branch 'master' into update_state
61c1eec
git subrepo clone --branch=update_state --force https://github.com/im…
1dc3cc1 
…pact27/spyder-kernels.git external-deps/spyder-kernels

subrepo:
  subdir:   "external-deps/spyder-kernels"
  merged:   "a071937c9"
upstream:
  origin:   "https://github.com/impact27/spyder-kernels.git"
  branch:   "update_state"
  commit:   "a071937c9"
git-subrepo:
  version:  "0.4.5"
  origin:   "https://github.com/ingydotnet/git-subrepo"
  commit:   "aa416e4"
@impact27
Copy link
Contributor Author

I noticed that errors in the frontend would result in pdb hanging. I removed error muting for pdb prompts as otherwise the console would hang without the user understanding why.

@ccordoba12
Copy link
Member

@impact27, please resync our subrepo since I merged spyder-ide/spyder-kernels#421. Then this should be ready.

git subrepo clone (merge) --branch=master --force https://github.com/…
021ecf8 
…spyder-ide/spyder-kernels.git external-deps/spyder-kernels

subrepo:
  subdir:   "external-deps/spyder-kernels"
  merged:   "18e2a889b"
upstream:
  origin:   "https://github.com/spyder-ide/spyder-kernels.git"
  branch:   "master"
  commit:   "18e2a889b"
git-subrepo:
  version:  "0.4.5"
  origin:   "https://github.com/ingydotnet/git-subrepo"
  commit:   "aa416e4"
ccordoba12
ccordoba12 approved these changes Feb 11, 2023
View reviewed changes
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @impact27! Great work here.

@ccordoba12 ccordoba12 merged commit e032831 into spyder-ide:master Feb 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ccordoba12 ccordoba12 ccordoba12 approved these changes

Assignees

@impact27 impact27

Labels
component:IPython Console type:Enhancement
Projects
None yet
Milestone
v6.0alpha1
Development

Successfully merging this pull request may close these issues.
2 participants
@impact27 @ccordoba12