-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR: Update Variable Explorer from the kernel #19842
Conversation
fec1f83
to
7a2ba46
Compare
…b.com/impact27/spyder-kernels.git external-deps/spyder-kernels subrepo: subdir: "external-deps/spyder-kernels" merged: "293c47f12" upstream: origin: "https://github.com/impact27/spyder-kernels.git" branch: "update_state" commit: "293c47f12" git-subrepo: version: "0.4.5" origin: "https://github.com/ingydotnet/git-subrepo" commit: "aa416e4"
d9f830c
to
864953e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @impact27 for this improvement! My review is mostly meant to improve your code's readability, but the implementation looks good to me.
Co-authored-by: Carlos Cordoba <ccordoba12@gmail.com>
…pact27/spyder-kernels.git external-deps/spyder-kernels subrepo: subdir: "external-deps/spyder-kernels" merged: "7c06d58c3" upstream: origin: "https://github.com/impact27/spyder-kernels.git" branch: "update_state" commit: "7c06d58c3" git-subrepo: version: "0.4.5" origin: "https://github.com/ingydotnet/git-subrepo" commit: "aa416e4"
…pact27/spyder-kernels.git external-deps/spyder-kernels subrepo: subdir: "external-deps/spyder-kernels" merged: "a071937c9" upstream: origin: "https://github.com/impact27/spyder-kernels.git" branch: "update_state" commit: "a071937c9" git-subrepo: version: "0.4.5" origin: "https://github.com/ingydotnet/git-subrepo" commit: "aa416e4"
I noticed that errors in the frontend would result in pdb hanging. I removed error muting for pdb prompts as otherwise the console would hang without the user understanding why. |
@impact27, please resync our subrepo since I merged spyder-ide/spyder-kernels#421. Then this should be ready. |
…spyder-ide/spyder-kernels.git external-deps/spyder-kernels subrepo: subdir: "external-deps/spyder-kernels" merged: "18e2a889b" upstream: origin: "https://github.com/spyder-ide/spyder-kernels.git" branch: "master" commit: "18e2a889b" git-subrepo: version: "0.4.5" origin: "https://github.com/ingydotnet/git-subrepo" commit: "aa416e4"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @impact27! Great work here.
Description of Changes
When several clients are connected to a kernel, only the client that sent the execute requests has his variable explorer updated. To solve this, the variable explorer is updated from the kernel instead.
goes with spyder-ide/spyder-kernels#421
Issue(s) Resolved
Fixes #
Affirmation
By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.
I certify the above statement is true and correct: