Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Use new API to handle creation and removal of debug toolbar and menu #19343

Merged

Conversation

ccordoba12
Copy link
Member

Description of Changes

  • Complement the work done by @impact27 on the Debugger plugin by using the new API to handle its toolbar and menu.

  • Remove old references to them on MainWindow.

  • Add actions that control the debugger (i.e. Step into, Continue, etc) to the Debug menu. This restores feature parity with Spyder 5.

    Before

    image

    After

    image

Affirmation

By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct: @ccordoba12

@ccordoba12 ccordoba12 added this to the v6.0alpha1 milestone Sep 6, 2022
@ccordoba12 ccordoba12 self-assigned this Sep 6, 2022
Copy link
Contributor

@impact27 impact27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@ccordoba12 ccordoba12 merged commit 78feb59 into spyder-ide:master Sep 6, 2022
@ccordoba12 ccordoba12 deleted the move-debug-toolbar-menu-to-plugin branch September 6, 2022 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants