-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR: Move breakpoints logic from editor plugin to debugger plugin #19208
Conversation
7fc3963
to
3403ca3
Compare
breakpoints to debugger fix
3403ca3
to
5bb4a3c
Compare
a068509
to
1cd058d
Compare
e2fe2bb
to
35c844e
Compare
@impact27, is this ready for review? |
Yes this is ready |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks pretty good! Thanks @impact27 for your work on it.
Co-authored-by: Carlos Cordoba <ccordoba12@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Second round of reviews for you @impact27.
|
||
from spyder.config.manager import CONF | ||
from spyder.config.base import _ | ||
from spyder.py3compat import to_text_string | ||
from spyder.api.manager import Manager | ||
from spyder.plugins.editor.utils.editor import BlockUserData | ||
from spyder.plugins.debugger.panels.debuggerpanel import DebuggerPanel | ||
from spyder.plugins.editor.utils.editor import get_file_language | ||
from spyder.plugins.editor.utils.languages import ALL_LANGUAGES | ||
|
||
|
||
def _load_all_breakpoints(): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not so sure because now the CONF is updated once instead of once for every editor. If I add these methods to BreakpointsManager I would loose this
Ok, I see. I thought my suggestion could be implemented easily, but we can see how to do it later.
Also what if the editor plugin is closed?
What do you mean by this?
Co-authored-by: Carlos Cordoba <ccordoba12@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Last review, then this should be ready.
Co-authored-by: Carlos Cordoba <ccordoba12@gmail.com>
Co-authored-by: Carlos Cordoba <ccordoba12@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for your hard work on this @impact27!
Description of Changes
depends on #19181
Issue(s) Resolved
Fixes #
Affirmation
By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.
I certify the above statement is true and correct: