PR: Move breakpoints logic from editor plugin to debugger plugin #19208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
impact27
force-pushed
the
move_breakpoints
branch
4 times, most recently
from
7fc3963
to
3403ca3
Compare
breakpoints to debugger fix
impact27
force-pushed
the
move_breakpoints
branch
from
3403ca3
to
5bb4a3c
Compare
added 2 commits
August 29, 2022 08:08
impact27
force-pushed
the
move_breakpoints
branch
from
a068509
to
1cd058d
Compare
impact27
force-pushed
the
move_breakpoints
branch
from
e2fe2bb
to
35c844e
Compare
ccordoba12
reviewed
Aug 31, 2022
impact27
changed the title
added 2 commits
August 31, 2022 18:35
|
@impact27, is this ready for review? |
|
Yes this is ready |
ccordoba12
reviewed
Sep 1, 2022
There was a problem hiding this comment.
This looks pretty good! Thanks @impact27 for your work on it.
Co-authored-by: Carlos Cordoba <ccordoba12@gmail.com>
ccordoba12
reviewed
Sep 1, 2022
|
|
||
| from spyder.config.manager import CONF | ||
| from spyder.config.base import _ | ||
| from spyder.py3compat import to_text_string | ||
| from spyder.api.manager import Manager | ||
| from spyder.plugins.editor.utils.editor import BlockUserData | ||
| from spyder.plugins.debugger.panels.debuggerpanel import DebuggerPanel | ||
| from spyder.plugins.editor.utils.editor import get_file_language | ||
| from spyder.plugins.editor.utils.languages import ALL_LANGUAGES | ||
|
|
||
|
|
||
| def _load_all_breakpoints(): |
There was a problem hiding this comment.
I am not so sure because now the CONF is updated once instead of once for every editor. If I add these methods to BreakpointsManager I would loose this
Ok, I see. I thought my suggestion could be implemented easily, but we can see how to do it later.
Also what if the editor plugin is closed?
What do you mean by this?
Co-authored-by: Carlos Cordoba <ccordoba12@gmail.com>
3 tasks
ccordoba12
reviewed
Sep 2, 2022
Co-authored-by: Carlos Cordoba <ccordoba12@gmail.com>
Co-authored-by: Carlos Cordoba <ccordoba12@gmail.com>
ccordoba12
approved these changes
Sep 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
depends on #19181
Issue(s) Resolved
Fixes #
Affirmation
By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.
I certify the above statement is true and correct: