-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR: Generalize Run plugin to support generic inputs and executors #17467
Conversation
Co-authored-by: Stephannie Jimenez Gacha <steff456@hotmail.com>
Hello @andfoy! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Comment last updated at 2022-07-14 00:18:24 UTC |
… Viewers Co-authored-by: Stephannie Jimenez Gacha <steff456@hotmail.com>
Co-authored-by: Stephannie Jimenez Gacha <steff456@hotmail.com>
Co-authored-by: Stephannie Jimenez Gacha <steff456@hotmail.com>
4e1f5aa
to
738e0fa
Compare
Co-authored-by: Stephannie Jimenez Gacha <steff456@hotmail.com>
…tors Co-authored-by: Stephannie Jimenez Gacha <steff456@hotmail.com>
Co-authored-by: Stephannie Jimenez Gacha <steff456@hotmail.com>
623fd86
to
e4a986e
Compare
Co-authored-by: Stephannie Jimenez Gacha <steff456@hotmail.com>
…nto split_run_editor
Co-authored-by: Stephannie Jimenez Gacha <steff456@hotmail.com>
Co-authored-by: Stephannie Jimenez Gacha <steff456@hotmail.com>
Co-authored-by: Stephannie Jimenez Gacha <steff456@hotmail.com>
Co-authored-by: Stephannie Jimenez Gacha <steff456@hotmail.com>
Co-authored-by: Stephannie Jimenez Gacha <steff456@hotmail.com>
Co-authored-by: Stephannie Jimenez Gacha <steff456@hotmail.com>
Co-authored-by: Stephannie Jimenez Gacha <steff456@hotmail.com>
Co-authored-by: Stephannie Jimenez Gacha <steff456@hotmail.com>
5497628
to
bc5ab32
Compare
- They are no longer needed because those widgets are now populated by the Run plugin. - Also, fix adding the Run toolbar to new Editor windows.
bc5ab32
to
d9f939f
Compare
e950c43
to
8215c66
Compare
54d47b8
to
ae36830
Compare
ae36830
to
5cf60eb
Compare
I think this is ready, so let's merge it. It still requires more work but that can be done in follow up PRs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Description of Changes
This PR will generalize the functioning of the Run plugin, and more specifically, the Run button itself, which will allow plugins to register run inputs and executors in a generic way. This will enable plugins such as spyder-terminal to run scripts and plugin designers may create other interfaces that have an executable output, examples of this, some sort of graph editor, or even the future plots panel.
This is being done as part of the tasks necessary to migrate the editor to the new API and is being tracked as part of #17468
Issue(s) Resolved
Fixes #
Affirmation
By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.
I certify the above statement is true and correct: