-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR: Use control channel for comms #16890
Conversation
…pact27/spyder-kernels.git external-deps/spyder-kernels subrepo: subdir: "external-deps/spyder-kernels" merged: "ea9c2930a0" upstream: origin: "https://github.com/impact27/spyder-kernels.git" branch: "comm_control" commit: "ea9c2930a0" git-subrepo: version: "0.4.3" origin: "???" commit: "???"
3bf79ff
to
648c313
Compare
…b.com/impact27/spyder-kernels.git external-deps/spyder-kernels subrepo: subdir: "external-deps/spyder-kernels" merged: "025f597c8" upstream: origin: "https://github.com/impact27/spyder-kernels.git" branch: "comm_control" commit: "025f597c8" git-subrepo: version: "0.4.1" origin: "https://github.com/ingydotnet/git-subrepo" commit: "a04d8c2"
@ccordoba12 |
…b.com/impact27/spyder-kernels.git external-deps/spyder-kernels subrepo: subdir: "external-deps/spyder-kernels" merged: "c2f7bebd1" upstream: origin: "https://github.com/impact27/spyder-kernels.git" branch: "comm_control" commit: "c2f7bebd1" git-subrepo: version: "0.4.1" origin: "https://github.com/ingydotnet/git-subrepo" commit: "a04d8c2" git subrepo clone --branch=comm_control --force https://github.com/impact27/spyder-kernels.git external-deps/spyder-kernels subrepo: subdir: "external-deps/spyder-kernels" merged: "2ba517c1b" upstream: origin: "https://github.com/impact27/spyder-kernels.git" branch: "comm_control" commit: "2ba517c1b" git-subrepo: version: "0.4.1" origin: "https://github.com/ingydotnet/git-subrepo" commit: "a04d8c2" git subrepo clone --branch=comm_control --force https://github.com/impact27/spyder-kernels.git external-deps/spyder-kernels subrepo: subdir: "external-deps/spyder-kernels" merged: "8503fba55" upstream: origin: "https://github.com/impact27/spyder-kernels.git" branch: "comm_control" commit: "8503fba55" git-subrepo: version: "0.4.1" origin: "https://github.com/ingydotnet/git-subrepo" commit: "a04d8c2"
The failed tests may not be related to this PR, see https://github.com/spyder-ide/spyder/pull/18256/checks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left a couple of tiny suggestions, otherwise looks good to me.
Co-authored-by: Carlos Cordoba <ccordoba12@gmail.com>
…b.com/impact27/spyder-kernels.git external-deps/spyder-kernels subrepo: subdir: "external-deps/spyder-kernels" merged: "04e37121a" upstream: origin: "https://github.com/impact27/spyder-kernels.git" branch: "comm_control" commit: "04e37121a" git-subrepo: version: "0.4.1" origin: "https://github.com/ingydotnet/git-subrepo" commit: "a04d8c2"
eaa7282
to
69b9baf
Compare
@impact27, please resync our subrepo with its latest |
…spyder-ide/spyder-kernels.git external-deps/spyder-kernels subrepo: subdir: "external-deps/spyder-kernels" merged: "8a161f6a1" upstream: origin: "https://github.com/spyder-ide/spyder-kernels.git" branch: "master" commit: "8a161f6a1" git-subrepo: version: "0.4.1" origin: "https://github.com/ingydotnet/git-subrepo" commit: "a04d8c2"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@impact27, a couple of small suggestions for you, then this should be ready.
Co-authored-by: Carlos Cordoba <ccordoba12@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks @impact27!
Description of Changes
Issue(s) Resolved
Fixes #14894
Affirmation
By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.
I certify the above statement is true and correct: