PR: Show Matplotlib backend state in status bar #14199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
impact27
force-pushed
the
interactive_matplotlib
branch
from
1d7f8d7
to
10f2433
Compare
impact27
changed the title
5 tasks
impact27
force-pushed
the
interactive_matplotlib
branch
from
11cdf36
to
e1e6a4f
Compare
3 tasks
impact27
force-pushed
the
interactive_matplotlib
branch
from
e25a437
to
b087203
Compare
impact27
force-pushed
the
interactive_matplotlib
branch
from
b087203
to
5b97f15
Compare
impact27
force-pushed
the
interactive_matplotlib
branch
from
12f87bc
to
5954ac1
Compare
Closed
impact27
force-pushed
the
interactive_matplotlib
branch
from
c41452f
to
b539fa9
Compare
impact27
force-pushed
the
interactive_matplotlib
branch
from
df10f53
to
156ba4e
Compare
Merged
3 tasks
impact27
force-pushed
the
interactive_matplotlib
branch
from
75b018b
to
66eca23
Compare
…ps://github.com/impact27/spyder-kernels.git external-deps/spyder-kernels subrepo: subdir: "external-deps/spyder-kernels" merged: "6861c5818" upstream: origin: "https://github.com/impact27/spyder-kernels.git" branch: "interactive_matplotlib" commit: "6861c5818" git-subrepo: version: "0.4.5" origin: "https://github.com/ingydotnet/git-subrepo" commit: "aa416e4"
…spyder-ide/spyder-kernels.git external-deps/spyder-kernels subrepo: subdir: "external-deps/spyder-kernels" merged: "163dc4ee6" upstream: origin: "https://github.com/spyder-ide/spyder-kernels.git" branch: "master" commit: "163dc4ee6" git-subrepo: version: "0.4.5" origin: "https://github.com/ingydotnet/git-subrepo" commit: "aa416e4"
ccordoba12
reviewed
Apr 17, 2023
There was a problem hiding this comment.
Thanks @impact27 for your patience with this one. I left some suggestions and comments for you.
Co-authored-by: Carlos Cordoba <ccordoba12@gmail.com>
|
Thanks @impact27 for addressing my review! I fixed some minor issues I found when testing your PR locally. Besides that, I think nothing else is needed here. So, after our tests pass, I'll merge it. |
ccordoba12
changed the title
- This will make Spyder start faster. - Also, check if Matplotlib has been imported when the main window is visible before calling on_mainwindow_visible for plugins. Otherwise, Spyder will crash on development mode due to the new MatplotlibStatus widget.
… empty Also, use that icon to represent the Plots plugin and in the Matplotlib status bar widget.
Also, improve its tooltip a bit.
ccordoba12
force-pushed
the
interactive_matplotlib
branch
from
b092060
to
ac3c646
Compare
ccordoba12
approved these changes
Jun 7, 2023
There was a problem hiding this comment.
This is a really nice addition, thanks @impact27 for your work on it!
Note: The failure in our tests is unrelated to this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Add matplotlib state to status bar and allows switching between inline and interactive by clicking the status bar.
Issue(s) Resolved
Fixes #
Affirmation
By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.
I certify the above statement is true and correct: