-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR: Show Matplotlib backend state in status bar #14199
PR: Show Matplotlib backend state in status bar #14199
Conversation
1d7f8d7
to
10f2433
Compare
11cdf36
to
e1e6a4f
Compare
e25a437
to
b087203
Compare
b087203
to
5b97f15
Compare
12f87bc
to
5954ac1
Compare
c41452f
to
b539fa9
Compare
df10f53
to
156ba4e
Compare
75b018b
to
66eca23
Compare
…ps://github.com/impact27/spyder-kernels.git external-deps/spyder-kernels subrepo: subdir: "external-deps/spyder-kernels" merged: "6861c5818" upstream: origin: "https://github.com/impact27/spyder-kernels.git" branch: "interactive_matplotlib" commit: "6861c5818" git-subrepo: version: "0.4.5" origin: "https://github.com/ingydotnet/git-subrepo" commit: "aa416e4"
…spyder-ide/spyder-kernels.git external-deps/spyder-kernels subrepo: subdir: "external-deps/spyder-kernels" merged: "163dc4ee6" upstream: origin: "https://github.com/spyder-ide/spyder-kernels.git" branch: "master" commit: "163dc4ee6" git-subrepo: version: "0.4.5" origin: "https://github.com/ingydotnet/git-subrepo" commit: "aa416e4"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @impact27 for your patience with this one. I left some suggestions and comments for you.
Co-authored-by: Carlos Cordoba <ccordoba12@gmail.com>
Thanks @impact27 for addressing my review! I fixed some minor issues I found when testing your PR locally. Besides that, I think nothing else is needed here. So, after our tests pass, I'll merge it. |
- This will make Spyder start faster. - Also, check if Matplotlib has been imported when the main window is visible before calling on_mainwindow_visible for plugins. Otherwise, Spyder will crash on development mode due to the new MatplotlibStatus widget.
… empty Also, use that icon to represent the Plots plugin and in the Matplotlib status bar widget.
Also, improve its tooltip a bit.
b092060
to
ac3c646
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a really nice addition, thanks @impact27 for your work on it!
Note: The failure in our tests is unrelated to this.
Description of Changes
Add matplotlib state to status bar and allows switching between inline and interactive by clicking the status bar.
Issue(s) Resolved
Fixes #
Affirmation
By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.
I certify the above statement is true and correct: