-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR: Add scroll line up/down keyboard shortcuts (Editor) #10990
PR: Add scroll line up/down keyboard shortcuts (Editor) #10990
Conversation
…plement_scoll_line_sc # Conflicts: # spyder/plugins/editor/widgets/tests/test_editor.py
So as I've said in gitter, I'm currently unable to work on master after PR #11064 because of the following error |
0cdd4e5
to
5a419ed
Compare
Hi @jnsebgosselin sorry for the sudden ping, but just wondering, is okay if I go ahead and finish this? Let me know! Edit: Will push a commit trying to fix the conflicts here |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One comment for you @dalthviz, the rest looks good to me.
spyder/plugins/editor/widgets/editorstack/tests/test_editorstack.py
Outdated
Show resolved
Hide resolved
@dalthviz awesome, thanks for finishing this! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jnsebgosselin for your here and @dalthviz for finishing it.
Description of Changes
Issue(s) Resolved
Fixes #10968
Affirmation
By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.
I certify the above statement is true and correct: Jean-Sébastien Gosselin