PR: Add scroll line up/down keyboard shortcuts (Editor) #10990
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goanpeca
reviewed
Dec 9, 2019
…plement_scoll_line_sc # Conflicts: # spyder/plugins/editor/widgets/tests/test_editor.py
|
So as I've said in gitter, I'm currently unable to work on master after PR #11064 because of the following error |
jnsebgosselin
force-pushed
the
implement_scoll_line_sc
branch
from
0cdd4e5
to
5a419ed
Compare
|
Hi @jnsebgosselin sorry for the sudden ping, but just wondering, is okay if I go ahead and finish this? Let me know! Edit: Will push a commit trying to fix the conflicts here |
ccordoba12
changed the title
ccordoba12
reviewed
Aug 3, 2023
spyder/plugins/editor/widgets/editorstack/tests/test_editorstack.py
Outdated
Show resolved
Hide resolved
ccordoba12
changed the title
|
@dalthviz awesome, thanks for finishing this! |
dalthviz
changed the title
ccordoba12
approved these changes
Aug 4, 2023
There was a problem hiding this comment.
Thanks @jnsebgosselin for your here and @dalthviz for finishing it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Issue(s) Resolved
Fixes #10968
Affirmation
By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.
I certify the above statement is true and correct: Jean-Sébastien Gosselin