Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing methods to SpyderPluginMixin #2117

Closed
spyder-bot opened this issue Feb 17, 2015 · 4 comments · Fixed by #2189
Closed

Add missing methods to SpyderPluginMixin #2117

spyder-bot opened this issue Feb 17, 2015 · 4 comments · Fixed by #2189

Comments

@spyder-bot
Copy link
Collaborator

From contrebasse on 2015-01-15T04:44:22Z

Spyder Version: 2.4.0dev (4711+: rb5a5ef2bb4d5 )
Python Version: 3.4.2
Qt Version : 4.8.6, PyQt4 (API v2) 4.11.3 on Linux
pyflakes >=0.6.0: 0.7.3 (OK)
pep8 >=0.6 : 1.5.7 (OK)
IPython >=1.0 : 2.3.1 (OK)
zmq >=2.1.11 : 14.4.1 (OK)
pygments >=1.6 : 2.0.1 (OK)
pandas >=0.13.1 : 0.15.2 (OK)
sphinx >=0.6.6 : 1.2.3 (OK)
psutil >=0.3 : 2.1.3 (OK)
jedi >=0.8.1 : 0.8.1-final0 (OK)
rope >=0.9.2 : 0.9.4-1 (OK)
matplotlib >=1.0: 1.4.2 (OK)
sympy >=0.7.0 : 0.7.6 (OK)
pylint >=0.25 : 1.4.0 (OK)

What steps will reproduce the problem?

  1. open or close files in the editor
    1. quit spyder
    2. start spyder

What is the expected output? What do you see instead?

I expect to have the same files opened as before closing spyder. Instead, I see the files that were open when starting spyder the previous time.

I tried to remove the .spuder2-py3 directory, and now each time I start spyder, I see only the dummy temp.py.

Please provide any additional information below

.
Same problem with pyqt and pyside.

Original issue: http://code.google.com/p/spyderlib/issues/detail?id=2117

@spyder-bot
Copy link
Collaborator Author

From contrebasse on 2015-01-15T02:18:28Z

OK, looks like it's because of my autopep8 plugin which doesn't have a closing_plugin method, wich is called since https://bitbucket.org/spyder-ide/spyderlib/commits/68b63205844b00e492c69ec8cdc0cd62a246f417 .

So, is this attribute mandatory for plugins ?

@spyder-bot
Copy link
Collaborator Author

From contrebasse on 2015-01-15T02:22:47Z

Adding the method to the plugin fixes the problem.

This should be added to SpyderPluginMixin so definig the method is optional. Same with apply_plugin_settings for example, which should be a no-op by default.

@spyder-bot
Copy link
Collaborator Author

From ccordoba12 on 2015-02-08T11:20:25Z

Could you create a pull request or at least upload a patch with your suggested changes?

I don't exactly understand what I need to do :-)

Labels: MS-v2.3.4 Cat-Settings

@spyder-bot
Copy link
Collaborator Author

From ccordoba12 on 2015-02-08T11:22:17Z

Summary: Add missing methods to SpyderPluginMixin

@ccordoba12 ccordoba12 modified the milestones: v2.4, v2.3.4 Feb 22, 2015
ccordoba12 added a commit that referenced this issue Feb 22, 2015
Provide a base implementation for closing_plugin

Fixes #2117
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants