Update version warning banner to always point to the latest stable docs #374
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Pull Request Checklist
Description of Changes
Currently, the warning banner for old (and new) versions embeds a link title and URL that hardcode the version number of the latest stable docs. With Sphinx-Multiversion that was fine, since all branches were rebuilt in sync so even the old banners would always be up to date, but with the new theme introduced in #367 , this will no longer be the case and unmaintained branches will be static, and not migrated to the new theme. Therefore, we need to update the old banner to be "evergreen" and point to the
/current/version rather than a hardcoded version value.I'll also fix any linkcheck issues that may come up.
Required for #367