Ignore case for QT_API env variable in qtpy submodules #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| import os | ||
|
|
||
| from qtpy import QT_API | ||
| from qtpy import API | ||
| from qtpy import PYQT5_API | ||
| from qtpy import PYQT4_API | ||
| from qtpy import PYSIDE_API | ||
| from qtpy import PythonQtError |
There was a problem hiding this comment.
BTW, why are those imports split into multiple lines ?
|
I like this one. Please unify |
|
It should be good, waiting for tests. |
ccordoba12
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is easier on the users, and the tests are currently failing because of this problem.
I got rid of the
os.environ[QT_API]lookups, because it makes qtpy rely too much on an external global state, while the environent is already pared in__init__.py. This makes the import thread safe, for example.With this I think that spyder-ide/spyder#3210 won't fail anymore.