Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Add Travis CI building and deployment to theme example site #2

Merged
merged 1 commit into from
Feb 19, 2019

Conversation

CAM-Gerlach
Copy link
Member

@CAM-Gerlach CAM-Gerlach commented Feb 18, 2019

This PR sets up the example site to build and deploy automatically to Github pages using Travis CI, as well as check that every PR at least builds successfully.

To complete the process, @ccordoba12 I either need admin on this repo, or you need to:

1 Activate Travis CI for this repo
2. Add your environment variables LEKTOR_DEPLOY_USERNAME and LEKTOR_DEPLOY_PASSWORD with your username and a personal access token (or a bot's, etc) in the Travis settings there
3. Trigger a build on this PR and make sure it works
4. Activate Github pages for this repo in the Github repo settings
5. Activate branch protection on master and gh-pages, restrict push access to both to admins and e.g. members of the website team (which you should presumably add me to :) ) and require reviews and status checks on master.

Finally, this can be merged, and the demo site should go live.

@CAM-Gerlach CAM-Gerlach added the enhancement New feature or request label Feb 18, 2019
@CAM-Gerlach CAM-Gerlach added this to the v1.0 milestone Feb 18, 2019
@CAM-Gerlach CAM-Gerlach self-assigned this Feb 18, 2019
@ccordoba12
Copy link
Member

To complete the process, @ccordoba12 I either need admin on this repo

You should be an admin now.

@ccordoba12 ccordoba12 removed their request for review February 19, 2019 09:34
@ccordoba12 ccordoba12 changed the title Add Travis CI building and deployment to theme example site PR: Add Travis CI building and deployment to theme example site Feb 19, 2019
@CAM-Gerlach CAM-Gerlach merged commit 39152bd into spyder-ide:master Feb 19, 2019
@CAM-Gerlach
Copy link
Member Author

Thanks @ccordoba12 ; Travis and Github Pages are now good to go, branch protection is set up (for master and gh-pages; I left legacy as it is for now), the description, link and tags are updated, and the demo site is live.

Now I just have to add support for mainpage flowblock nesting and add an option to make Services/Author tiles clickable links, which will allow for easily re-implementing the Sponsors section site-side with most of the fixes/enhancements I proposed in the original PR, and then I can implement it on Spyder-Website itself for your review.

I can also submit it to the Lektor-Themes repo and the Lektor website gallery at this point, though I may as well do those two things first to ensure we can properly show it off on our site as well as mine and the demo one.

@ccordoba12
Copy link
Member

Ok, thanks! It looks really nice!

@CAM-Gerlach CAM-Gerlach deleted the add-ci-ghpages branch May 14, 2019 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants