update vp token definition #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ryanmtate
force-pushed
the
skit-562-update-oid4vp-rs-vptoken-definition-per-the-specification
branch
3 times, most recently
from
e82c109
to
168288e
Compare
Ryanmtate
force-pushed
the
skit-562-update-oid4vp-rs-vptoken-definition-per-the-specification
branch
from
168288e
to
eeffa6c
Compare
cobward
requested changes
Sep 19, 2024
Ryanmtate
force-pushed
the
skit-562-update-oid4vp-rs-vptoken-definition-per-the-specification
branch
3 times, most recently
from
3dcdb7e
to
0766bd2
Compare
Ryanmtate
changed the base branch from
main
to
skit-566-bumppatch-ssi-version-pending-release
cobward
requested changes
Sep 24, 2024
src/core/response/parameters.rs
Outdated
| type Error = Error; | ||
|
|
||
| fn try_from(vp: AnyJsonPresentation) -> Result<Self, Self::Error> { | ||
| Ok(VpToken::Single(serde_json::to_vec(&vp)?)) |
There was a problem hiding this comment.
A JsonPresentation is a W3C Verifiable Presentation, which is a JSON object. Therefore it should be represented as VpToken::SingleAsMap (example in the OID4VP spec).
Ryanmtate
changed the base branch from
skit-566-bumppatch-ssi-version-pending-release
to
main
Signed-off-by: Ryan Tate <ryan.michael.tate@gmail.com> use base64 url encoding Signed-off-by: Ryan Tate <ryan.michael.tate@gmail.com> remove vp builder, use AnyJsonPresentation Signed-off-by: Ryan Tate <ryan.michael.tate@gmail.com> parse VC from VerifiableCredential to SpeicalizedJsonCredential to use JsonPresentation Signed-off-by: Ryan Tate <ryan.michael.tate@gmail.com> update comments Signed-off-by: Ryan Tate <ryan.michael.tate@gmail.com> fix from any json presentation for vp token impl Signed-off-by: Ryan Tate <ryan.michael.tate@gmail.com>
Signed-off-by: Ryan Tate <ryan.michael.tate@gmail.com>
Co-authored-by: Jacob <jacob.ward@spruceid.com>
Co-authored-by: Jacob <jacob.ward@spruceid.com>
Signed-off-by: Ryan Tate <ryan.michael.tate@gmail.com>
Ryanmtate
force-pushed
the
skit-562-update-oid4vp-rs-vptoken-definition-per-the-specification
branch
from
80a5f6b
to
cdf2a89
Compare
Signed-off-by: Ryan Tate <ryan.michael.tate@gmail.com>
cobward
approved these changes
Sep 26, 2024
w4ll3
reviewed
Sep 26, 2024
Signed-off-by: Ryan Tate <rmt@spruceid.local>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces updates to the
VpTokendefinition:The PR includes aTryFrom<VerifiablePresentation> for VpTokenmethod for convenience.Includes a
TryFrom<AnyJsonPresentation> for VpTokenas a convenience method.