Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Modify service override registration so they're mapped to a "service" #85

Merged

Conversation

ollieread
Copy link
Member

This PR addresses #84 with a refactor so that service overrides are registered against services, which are arbitrary strings that represent the “service” they override.

@ollieread ollieread added type: refactor Refactoring of code status: accepted The issue has been accepted/acknowledged and is being actioned or will be labels Jan 7, 2025
@ollieread ollieread self-assigned this Jan 7, 2025
Copy link

codecov bot commented Jan 7, 2025

Codecov Report

Attention: Patch coverage is 47.05882% with 9 lines in your changes missing coverage. Please review.

Project coverage is 54.19%. Comparing base (23b4d58) to head (82d431d).
Report is 7 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/Concerns/HandlesServiceOverrides.php 38.46% 8 Missing ⚠️
src/SproutServiceProvider.php 75.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main      #85      +/-   ##
============================================
+ Coverage     54.04%   54.19%   +0.14%     
- Complexity      476      484       +8     
============================================
  Files            65       65              
  Lines          1347     1360      +13     
============================================
+ Hits            728      737       +9     
- Misses          619      623       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ollieread ollieread merged commit cf99a0c into main Jan 9, 2025
3 of 4 checks passed
@ollieread ollieread deleted the refactor/register-service-overrides-against-services branch January 9, 2025 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: accepted The issue has been accepted/acknowledged and is being actioned or will be type: refactor Refactoring of code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant