Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support full aria controls provided by draftJS #436

Closed
dwjohnston opened this issue Feb 17, 2021 · 2 comments
Closed

Support full aria controls provided by draftJS #436

dwjohnston opened this issue Feb 17, 2021 · 2 comments
Labels
enhancement New feature or request
Milestone

Comments

@dwjohnston
Copy link
Contributor

Is your proposal related to a problem?

It looks like the only aria tag you are providing is the the ariaDescribedBy.

This makes it difficult to access the component when using React Testing Library.

Describe the solution you’d like

Pass the full list of aria props as listed here on to the draft js component:

https://github.com/facebook/draft-js/blob/master/src/component/base/DraftEditorProps.js

Describe alternatives you’ve considered

It looks like you aren't support arbitrary passing of props to base elements, like Material-UI often does.

Additional context

(Write your answer here.)

@dwjohnston dwjohnston added the enhancement New feature or request label Feb 17, 2021
dwjohnston added a commit to dwjohnston/draftail that referenced this issue Feb 17, 2021
@thibaudcolas
Copy link
Collaborator

Hey @dwjohnston, thank you for the report, and the PR. Not having those props seems like oversight from my part more than anything.

I’ll triple check how the Draft.js 0.10 -> 0.11 situation might affect this and review your PR.

@thibaudcolas thibaudcolas added this to the v1.4.0 milestone Feb 22, 2021
@thibaudcolas thibaudcolas modified the milestones: v1.4.0, v1.5.0 Apr 14, 2021
thibaudcolas pushed a commit to dwjohnston/draftail that referenced this issue May 19, 2022
@thibaudcolas thibaudcolas modified the milestones: v1.5.0, v2.0.0 Jul 12, 2022
@thibaudcolas
Copy link
Collaborator

Implemented in #438.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants