Typesave serialization of openapi spec#978
Merged
bnasslahsen merged 1 commit intospringdoc:masterfrom Dec 11, 2020
Merged
Conversation
bnasslahsen
approved these changes
Dec 11, 2020
Collaborator
bnasslahsen
left a comment
There was a problem hiding this comment.
thank you @kevinraddatz for your contribution;
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was trying to integrate spring cloud config into our project and used the openAPI() bean for testing.
By default spring uses the proxy method
TARGET_CLASSto generate a refreshScope bean which adds multiple properties which will be serialized by the objectMapper. Serialization of those properties results in an infinite loop and thus in a StackOverflowError.With these changes the openAPI object will be serialized for the OpenAPI class, ignoring the properties added by spring.