Replaced deprecated org.springframework.core.LocalVariableTableParameterNameDiscoverer with org.springframework.core.StandardReflectionParameterNameDiscoverer #1959
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…terNameDiscoverer with org.springframework.core.DefaultParameterNameDiscoverer
|
I have fixed your PR: |
bnasslahsen
changed the title
|
But why? StandardReflectionParameterNameDiscoverer can't work for every library. DefaultParameterNameDiscoverer is better, cause it uses all posible options. First Kotlin, if exists, then StandardReflectionParameterNameDiscoverer for classes that were compiled with Java 8+ with -parameters option and then LocalVariableTableParameterNameDiscoverer for all other classes. That's how it works in Spring Framework |
|
You were breaking tests ... |
|
In which version will this be included? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.