Skip to content

Make springdoc-openapi-webmvc-core an optional dependency of springdo… #1358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 2, 2021

Conversation

mshima
Copy link
Contributor

@mshima mshima commented Dec 2, 2021

…c-openapi-data-rest

springdoc-openapi-webmvc-core brings spring-webmvc in.
Making ResponseEntityExceptionHandler to exist and causing a linkage error on missing servlet classes.

responseEntityExceptionHandlerClass = Class.forName("org.springframework.web.servlet.mvc.method.annotation.ResponseEntityExceptionHandler");

Closes #1357

…c-openapi-data-rest

springdoc-openapi-webmvc-core brings spring-webmvc in.
Making `ResponseEntityExceptionHandler` to exist and causing a linkage error on missing servlet classes.
https://github.com/springdoc/springdoc-openapi/blob/476b012cb23e93663ffdc87538a94690a5a557cc/springdoc-openapi-common/src/main/java/org/springdoc/core/GenericResponseService.java#L115
@bnasslahsen
Copy link
Collaborator

@mshima,

Thank you for your contribution to the project!

@bnasslahsen bnasslahsen merged commit d4629da into springdoc:master Dec 2, 2021
@mshima mshima deleted the patch-1 branch April 12, 2024 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SpringDocWebFluxConfiguration throws NoClassDefFoundError: javax/servlet/ServletException
2 participants