Use Publisher as response wrapper to ignore instead of Mono #1290
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your change is creating many regressions. |
sokomishalov
force-pushed
the
feature/use-publisher-as-response-type-wrapper
branch
4 times, most recently
from
d7d384e to
7303555
Compare
|
@bnasslahsen added a test to cover changes. |
|
Tests for webflux-core are still failing. |
sokomishalov
force-pushed
the
feature/use-publisher-as-response-type-wrapper
branch
from
7303555 to
865e47f
Compare
|
@bnasslahsen my bad, but failing tests occurred because of the fix - actuator's endpoints have return type |
sokomishalov
deleted the
feature/use-publisher-as-response-type-wrapper
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More abstract way to cover wrappers since spring supports any Publisher implementation.
My main concern is that Flux is also Publisher implementation and if it could break something.