Fix server address customizing in case of enabled pre-loading mode #1289
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please make sure, you add a test related to your code changes as well. |
sokomishalov
force-pushed
the
bugfix/server-customizer-fix
branch
from
19c05c2 to
964cbb6
Compare
sokomishalov
force-pushed
the
bugfix/server-customizer-fix
branch
from
964cbb6 to
7a90e0e
Compare
|
@bnasslahsen added test to cover the fix. But actually fix was even easier - we just need to check mutated new servers to be present instead of older ones. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.