SpringdocRouteBuilder redundant parameter

[Sam-Kruglov]

During nesting, there is a redunant operation builder consumer, which I always leave empty. Does that have any purpose in mind?

SpringdocRouteBuilder.route()
          .nest(
                  RequestPredicates.path("/users").and(RequestPredicates.accept(APPLICATION_JSON)),
                  Supplier {
                    SpringdocRouteBuilder.route()
                            .GET("", userHandler::getById, Consumer { it.beanClass(UserService::class.java).beanMethod("getById") })
                            ...
                            .build()
                  },
                  {} // what's the point of that?
          ).build()

[bnasslahsen]

@Sam-Kruglov,

It's not required to use SpringdocRouteBuilder.route().nest(), unless you want to add attributes to the resulting nested route as well.

If you only need to add attributes for Routes that are defined as parameter of nest, you can use RouterFunctions.nest, which is more relevant in this case.

You can see some code samples for the nest:

• springdoc-openapi/springdoc-openapi-webflux-core/src/test/java/test/org/springdoc/api/app90/book/BookRouter.java

  Line 62 in f99176f

  RouterFunction<?> routes2() {

[Sam-Kruglov]

Well, I could do SpringdocRouteBuilder.route().GET(...).GET(...).PUT(...).build().and(RouterFunctions.nest(...)) but I would rather do SpringdocRouteBuilder.route().GET(...).GET(...).PUT(...).nest(...).build() it would look better. Just adding one overloaded SpringdocRouteBuilder#nest without operation customizer would be nicer IMO

[bnasslahsen]

Nothing prevents you from submitting a PR, if you estimate it will be more handy from developer perspective.

[Sam-Kruglov]

FYI just found that the suggested solution does not work for 2+ level nesting. If I nest to /users and then deeper I nest to /groups then this .build().and(nest(...)) will result in /groups url. It is required to do .nest(...).build() to get /users/groups

[bnasslahsen]

@Sam-Kruglov,

This should work out of the box. If it's not the case, there is an issue there...