eclipse quick search... make results box NOT modal

[mattcsl]

This is for the quick search plugin. Not sure if this is the right place, but can we PLEASE make the results box NOT modal. Thanks!

[spring-projects-issues]

(comment in Pivotal Tracker added by Kris De Volder:)

I've changed the dialog to be non-modal.

I also added a 'keep open' option in the pulldown menu on the top-right corner of the dialog.

So, the dialog is allways modeless now (so you can click outside the dialog and use the editor etc).

The keep open option does not affect this, but it determines whether the dialog closes when you make a selection by double-click or enter key (clicking the ok button will still always close the dialog).

For acceptance testing. There are 3 ways to make a selection:

• double click a item
• select item (arrows keys or click), then press enter
• press ok button.

The behavior (whether dialog is closed) is affected by the 'keep open' option which can be on or off.

So there are 6 (2 times 3) scenarios to try out.

[mattcsl]

Thanks so much for doing this! How do I go about testing this in eclipse? I currently am running the Eclipse Quicksearch plugin 3.9.7.201812200835-RELEASE. How do I upgrade it to 4.1.2-RELEASE? I know how to clone the git repo. What are the next steps?

[kdvolder]

The easiest way to try it is from nightly/snapshot build. For qicksearch component you can install it from this update site:

https://dist.springsource.com/snapshot/TOOLS/eclipse-integration-commons/nightly

Do not click the link above. This doesn't work. What you do instead is:

• In STS open "Help >> Install New Software"
• Paste the update site url into the 'work with' box at the top of the dialog
• Select "Eclipse quicksearch" under "Core / Eclipse Integration Commons"
• Click Next and follow the dialog to its logical conclusion.

After STS is restarted you should have a new version of the quicksearch plugin.

This should work fine with the version of STS you have.

[spring-projects-issues]

(comment in Pivotal Tracker added by Kris De Volder:)

Testing the nightly update site I noticed the new version of the dialog is not resizable. I think the old one was.

I found that somewhat annoying, especially when the dialog is used as a modeless dialog. You kind of want to be able to downsize it and set it aside so you can use the rest of of your screen for other work.

So I just pushed a small tweak that makes the dialog resizable again.

[kdvolder]

@mattcsl

You may want to wait for this build to complete: https://build.spring.io/browse/IDE-COMMONSE44CI-430
As mentioned above. My first 'attempt' made the dialog no longer resizable.

[spring-projects-issues]

(comment in Pivotal Tracker added by Kris De Volder:)

Hmm... my little tweak to make dialog resizable seems to have broken the 'Keep Open' option somehow. The dialog now allways closes when I select an item.

Invesitigating.

[spring-projects-issues]

(comment in Pivotal Tracker added by Kris De Volder:)

Okay so, couldn't seem to find a way that makes it work so pressing 'enter' wouldn't close the dialog but clicking ok would. Somehow pressing enter also cause a 'ok button' even to be fired. So it seems to be all or nothing.

I changed it so now ok button, pressing enter or double clicking allways handled the same way. So if the 'Keep open' option is selected it will keep the dialog open for all 3 cases.

The best I can do for now.