Skip to content

Conversation

@Jarjanazy
Copy link

No description provided.

@fmbenhassine
Copy link
Contributor

Thank you for the PR! I like the refactorings your introduced to improve the code.

However, the package restructuring is a breaking change and I would like to address it in a separate PR. Please remove it from this PR and rebase the commits on the latest main.

Thank you upfront.

@fmbenhassine fmbenhassine added this to the 3.4.1 milestone Apr 25, 2025
@fmbenhassine fmbenhassine added the status/need-feedback Calling participant to provide feedback label Apr 25, 2025
@fmbenhassine fmbenhassine modified the milestones: 3.4.1, 4.0.0 Jul 31, 2025
@fmbenhassine
Copy link
Contributor

@Jarjanazy Have you got a chance to update this PR? see #674 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status/need-feedback Calling participant to provide feedback

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants