CommandRegistration.Builder with lambdas #1142
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is awesome! Thank you for your PR. I planned #1127 for the next release so it would be great if we can merge this PR in it. Can you please rebase it on the latest main and remove all formatting changes? Thank you upfront. |
fmbenhassine
added
the
status/need-feedback
Signed-off-by: heavynimbus <hugo.wieder@gmail.com>
Update to Commons-IO 2.18.0 Signed-off-by: heavynimbus <hugo.wieder@gmail.com>
Signed-off-by: heavynimbus <hugo.wieder@gmail.com>
Signed-off-by: heavynimbus <hugo.wieder@gmail.com>
Signed-off-by: heavynimbus <hugo.wieder@gmail.com>
Signed-off-by: heavynimbus <hugo.wieder@gmail.com>
Signed-off-by: heavynimbus <hugo.wieder@gmail.com>
Signed-off-by: heavynimbus <hugo.wieder@gmail.com>
Signed-off-by: heavynimbus <hugo.wieder@gmail.com>
Signed-off-by: heavynimbus <hugo.wieder@gmail.com>
Signed-off-by: heavynimbus <hugo.wieder@gmail.com>
Signed-off-by: heavynimbus <hugo.wieder@gmail.com>
Signed-off-by: heavynimbus <hugo.wieder@gmail.com>
Spring Boot 3.5 updated JUnit Jupiter from v5.11 to v5.12. With this new version, the junit-platform-launcher dependency must be declared explicitly. Signed-off-by: heavynimbus <hugo.wieder@gmail.com>
fix type Signed-off-by: benson-yeh <126453098+benson-yeh@users.noreply.github.com> Signed-off-by: heavynimbus <hugo.wieder@gmail.com>
Signed-off-by: heavynimbus <hugo.wieder@gmail.com>
Signed-off-by: heavynimbus <hugo.wieder@gmail.com>
Signed-off-by: heavynimbus <hugo.wieder@gmail.com>
- Bump node-pty from 0.11.0-beta19 to 1.0.0 - Bump xterm-headless from 4.18.0 to 5.5.0 - Rename xterm-headless to @xterm/headless as per https://www.npmjs.com/package/xterm-headless - Unpin Python 3.11 in e2e test by reverting commit spring-projects@8097f1e because it's no longer necessary as explained in spring-projects#909 (comment) - Fixes spring-projects#909 - Fixes spring-projects#921 Signed-off-by: heavynimbus <hugo.wieder@gmail.com>
heavynimbus
force-pushed
the
feat/command-registration
branch
from
6fed160 to
c4894b4
Compare
|
@heavynimbus Any reason you closed this PR? Is that because it was not easy to rebase on the latest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is intended to fix issue #1127
I added all functions of
CommandRegistration.Builderthat have aConsumer<?Spec>to avoid chaining with the and function from specifications. This change improves code readability and indentation.This is my first contribution. Please let me know if there are any issues or if I need to make any adjustments.