Unexpected comma inserted at the end of the parsed message

[denberr95]

HI,

I'm implementing a CLI using spring-shell 3.1.0 and spring boot 3.1.0.
During testing I have seen that parsing the message from vscode produces this result:

@Command(group = "SAMPLE", command = "sample")
public class SampleCmd {

    @Command(description = "TEST COMMAND", command = "create")
    public void create(
            @Option(description = "Name of the cluster", required = true) String name,
            @Option(description = "Setup topology of API Management (Accepted values: CLOUD, LOCAL)", required = true) @Pattern(message = "Accepted values: CLOUD, LOCAL", regexp = "CLOUD|LOCAL") String envType,
            @Option(description = "API host", defaultValue = "my.host.com") String apiHost,
            @Option(description = "API port", defaultValue = "443") int apiPort,
            @Option(description = "API Base Path", defaultValue = "/v3") String apiBasePath,
            @Option(description = "Enable HTTPS", defaultValue = "true") boolean useSsl) {
        System.out.println("OK");
    }

TEST 1: OK

TEST 2: OK

TEST 3: KO Because when parsing the parameters a "," is added to the value and the validator throws an exception

TEST 4: KO Because when parsing the parameters a "," is added to the value and the validator throws an exception

TEST 5: KO Because when parsing the parameters a ","

TEST 6: KO Because when parsing the parameters a ","

I have enabled all logging to capture events and message parsing: application.log.zip

[jvalkeal]

Thanks for the report. I see a same and it's a bit strange. I'll add comments when I know more about a root cause.

[jvalkeal]

Bug is in ExtendedDefaultParser which were originally copied from jline and modified for some other needs in a spring-shell. If cursor position was at the end of a line an empty argument were added, which then caused option to get two arguments and as on default there's no arity settings, conversion then added that comma(Default spring conversion logic from collection to string).

This was a good catch!

[jvalkeal]

This bug doesn't cause issues in 3.0.x or 2.1.x as actual spring-shell parsing framework discards extra empty args. JLine parser used in interactive mode is different than command line parsing in spring-shell. Should still backport.