Skip to content

PathInput for existing directories #497

Closed
@timtebeek

Description

@timtebeek

Spring Boot Migrator has a scan option where users enter an existing directory. At first glance PathInput seemed a good fit, but almost immediately we saw it's hardcoded to exclude existing directories. And since checkPath is private, it's not easy to adjust this behaviour.

How would you recommend we ask users to input an existing directory?
And is this something to contribute back here?

I could see a number of options:

  1. Make checkPath protected, with an override dropping the directory requirement.
  2. Add a flag argument on whether to allow directories
  3. Add an argument to test/filter files for applicability
  4. Fully new DirectoryInput flow component
  5. Stick with @ShellOption valueProvider
  6. Nothing in spring-shell; users should implement their own component.
  7. Others?

Any input much appreciated. :)

Metadata

Metadata

Assignees

No one assigned

    Labels

    status/invalidMistake, bogus, old, bye bye

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions