Disabled shell under 2.1.0-M2 still registers Spring managed Beans

[ullenboom]

A disabled shell

spring.shell.interactive.enabled=false

should not instantiate any shell components or beans.

However, mixing Shell-Start + Web-Starter and enabled=false will lead to

the bean 'themeResolver', defined in class path resource [org/springframework/shell/boot/ThemingAutoConfiguration.class], could not be registered. A bean with that name has already been defined in class path resource [org/springframework/boot/autoconfigure/web/servlet/WebMvcAutoConfiguration$EnableWebMvcConfiguration.class] and overriding is disabled.

[onobc]

Hi @ullenboom

The spring.shell.interactive.enabled property only controls whether or not the Interactive shell runner is enabled. Each runner has a similar property. There is currently no coarse-grained "enabled" property to control all-of-the-things.

I did notice the latter issue w/ the themeResolver as well and have a fix for it w/in #372. Also, the exception is unrelated to the enabled property (ie it happens w/ or w/o enabled set) - its solely the web-starter + this+starter that has clashing bean name.

Can you elaborate a bit more on your use case you are trying to solve by disabling the shell entirely? You can effectively cause it to not handle any requests by setting all runners to disabled such as:

spring:
  shell:
    interactive.enabled: false
    noninteractive.enabled: false
    script.enabled: false

or by excluding the org.springframework.shell.boot.ShellRunnerAutoConfiguration.

[ullenboom]

Hi @onobc, if you rename the themeResolver to shellThemeResolver than this will work for me. Then the conflict with Web is solved, and I don't need to switch off the entire shell anymore.

Background (#365 (comment)): In my courses, I'm using the shell for interactive applications for all the basics: DI/IoC, configuration, JDBC, JPA, and so on. Then I transition to RESTful web services and I don't need the shell anymore, so I switch if off. This would be easier with just setting spring.shell.interactive.enabled=false. During the course transition to upcoming Spring Boot 3 and the current Spring Shell version, I encountered several obstacles.

[onobc]

Hi @ullenboom ,
Thanks for the background - very cool.

This would be easier with just setting spring.shell.interactive.enabled=false.

The best bet may be to exclude the auto-config on the @SpringBootApplication to achieve that same effect. See if that works for you.

During the course transition to upcoming Spring Boot 3 and the current Spring Shell version, I encountered several obstacles.

Thanks for the reports on this. Hopefully, those are the last of the obstacles. However, until #356 is complete there are no guarantees. Please let us know when/if you run into obstacles in that ticket though as it will likely help speed that along when we start working on it.

[jvalkeal]

Maybe we should add spring.shell.enabled property as traditionally most of a boot autoconfigs have global flag for feature.

[onobc]

@ullenboom I am going to close this now since the circular dep is covered elsewhere and we have a current workaround and we have an issue to improve the property driven disablement.