Grid fixed item size goes to bottom right

[jvalkeal]

Using GridView with zero column/row sizes causes item to be placed into bottom-right when user would expect it to go top-left:

Something like when doing tests:

BoxView box1 = new BoxView();
BoxView sbox1 = spy(box1);
GridView grid = new GridView();

grid.setShowBorders(false);
grid.setRowSize(1);
grid.setColumnSize(1);
grid.setShowBorder(false);
grid.addItem(sbox1, 0, 0, 1, 1, 0, 0);

grid.setRect(0, 0, 10, 10);
grid.draw(screen10x10);

verify(sbox1).setRect(0, 0, 1, 1);

For example:

+---------+
|         |
|         |
|        X|
+---------+

When it should be:

+---------+
|X        |
|         |
|         |
+---------+

Logic came from golang tview grid component and it looks like it's "conceptually" broken there as well.

[jvalkeal]

Trouble looks to be here:

spring-shell/spring-shell-core/src/main/java/org/springframework/shell/component/view/control/GridView.java

Lines 533 to 540 in 19f2570

	int last = rowPos.length - 1;
	if (rowPos[last] + rowHeight[last] + border - offsetY < height) {
	offsetY = rowPos[last] - height + rowHeight[last] + border;
	}
	last = columnPos.length - 1;
	if (columnPos[last] + columnWidth[last] + border - offsetX < width) {
	offsetX = columnPos[last] - width + columnWidth[last] + border;
	}

Need to think if making that configurable makes sense and drive logic through better tests.

[jvalkeal]

There was fix for this in tview where above lines were simply removed to fix the issue. We can probably do same.