Skip to content

Consider making Session implementations public #2258

Open
@marcusdacoregio

Description

@marcusdacoregio

Expected Behavior

It should be possible to extend or delegate to those implementations.

Current Behavior

  • SessionRepository implementations are open for extension but cannot be extended, e.g. there is no way to override createSession or save methods.
  • This issue mentions that the MongoSession is an internal implementation detail of the MongoIndexedSessionRepository implementation. That actually is not 100% true since MongoSession is returned by the API.
  • The AbstractMongoSessionConverter is meant to be extended accordingly to its javadoc, but it is not possible since its abstract methods work with MongoSession and that implementation is package-private
  • Since each implementation is part of the public API, it is strange that they are not public

Context

Metadata

Metadata

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions