Fix inconsistent OAuth2 login redirect URI action in MVC stack #17770
+3
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an inconsistency in the Spring Security OAuth2 client where the MVC stack generates an incorrect OAuth2 login redirect URI due to using "authorize" as the default action, unlike the Reactive stack which uses "login".
Closes: gh-16941
Problem
DefaultOAuth2AuthorizationRequestResolver
) sets the redirect URI action to "authorize", resulting in URIs like/authorize/oauth2/code/{registrationId}
./login/oauth2/code/{registrationId}
.Changes
resolve(HttpServletRequest, String)
method in MVC resolver to always use "login" as the redirect URI action.Before:
After:
Impact & Benefits
Please review and provide feedback. Thank you.