Skip to content

Fixed assertion in DefaultGenerateOneTimeTokenRequestResolver #16507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 3, 2025

Conversation

franticticktick
Copy link
Contributor

Fixed assertion in DefaultGenerateOneTimeTokenRequestResolver.

Copy link
Contributor

@Tejas-Teju Tejas-Teju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks good to me @franticticktick

Any thoughts on the commit message?
Message: Fix setExpiresIn assertion in DefaultGenerateOneTimeTokenRequestResolver

Refer Commit Guidelines

@franticticktick
Copy link
Contributor Author

franticticktick commented Jan 31, 2025

Changes looks good to me @franticticktick

Thank you so much, I'm happy that you liked it :)

Please read carefully the guideline that you sent here:

Format commit messages using 55 characters for the subject line, 72 characters per line for the description, followed by the issue fixed, for example, Closes gh-22276.

Your solution fits the description rather, but not the commit message. This PR has a little polish, it does not need to be tracked or described in detail. I recommend that you look at other commits in spring security to see how polishing is done. The commit message fully reflects the essence of the polish, and if it is confusing, then one of the maintainers will definitely note it in the review.

@jzheaux jzheaux self-assigned this Feb 3, 2025
@jzheaux jzheaux added in: web An issue in web modules (web, webmvc) type: bug A general bug and removed status: waiting-for-triage An issue we've not yet triaged labels Feb 3, 2025
@jzheaux jzheaux added this to the 6.5.0-M2 milestone Feb 3, 2025
Signed-off-by: Max Batischev <mblancer@mail.ru>
@jzheaux
Copy link
Contributor

jzheaux commented Feb 3, 2025

Thanks @Tejas-Teju and @franticticktick both for taking a minute to review the guidelines. The only thing that I would change is to avoid past tense. I'm not very good at enforcing it since it's such a minor point; however, I'd like to recommit myself to encouraging the practice. As such, I updated the commit message and will merge once the build completes.

@jzheaux jzheaux merged commit 61d92e9 into spring-projects:main Feb 3, 2025
6 checks passed
@jzheaux
Copy link
Contributor

jzheaux commented Feb 3, 2025

Thanks, @franticticktick! This is now merged into main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: web An issue in web modules (web, webmvc) type: bug A general bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants