Make PublicKeyCredentialRequestOptions Serializable

[franticticktick]

Closes gh-16432

[rwinch]

Thanks for the Pull Request. Historically the serialVersionUID no longer used for new classes implementing Serializable. Going forward we should generate a serialVersionUID.

[franticticktick]

Hi @rwinch, thanks for feedback. If we use the generated serialVersionUID SpringSecurityCoreVersionSerializableTests will not work. It only works with SpringSecurityCoreVersion. Maybe we should add such support to SpringSecurityCoreVersionSerializableTests?

[rwinch]

Please take a look at 6f379aa which was progress towards gh-16276 for an example for how to implement it. It uses generated serialVersionUID and adds tests. The ticket gh-16276 also has instructions on how to address it.

NOTE: This PR has some overlap with gh-16285 (which I provided the same advice for)

[franticticktick]

Thanks for help @rwinch. Could you review changes please?

[rwinch]

Thanks for the PR! I've provided feedback inline

[rwinch]

It looks like this failed to write

[rwinch]

I like that you used a constant value here vs generating a new value. Please use a more realistic value. To make this easy I recently added TestBytes.get() gh-16461

[franticticktick]

ImmutableAuthenticationExtensionClientInput has generic parameter, so SpringSecurityCoreVersionSerializableTests doesn't work. To serialize the class I used this trick:

Object instance;
if(clazz.equals(ImmutableAuthenticationExtensionsClientInput.class)) {
	instance = instancioWithParameter((Class<ImmutableAuthenticationExtensionsClientInput>) clazz)
			.create();
} else {
	instance = instancioWithDefaults(clazz).create();
}

private static InstancioApi<?> instancioWithParameter(Class<ImmutableAuthenticationExtensionsClientInput> clazz) {
	InstancioApi<?> instancio = Instancio.of(clazz).withTypeParameters(Boolean.class);
	if (generatorByClassName.containsKey(clazz)) {
		instancio.supply(Select.all(clazz), generatorByClassName.get(clazz));
	}
	return instancio;
}

Perhaps there is an easier way to do this. We should think about this.

[rwinch]

Please use (or at least start with) TestPublicKeyCredentialRequestOptions

[franticticktick]

SpringSecurityCoreVersionSerializableTests#serializeAndDeserializeAreEqual does not work due to ImmutableAuthenticationExtensionsClientInput. As I already said, it can be serialized, but due to specifying a parameter with a generic, test serializeAndDeserializeAreEqual will fail. I don't see an easy way to solve this problem. @rwinch could you help please?

[rwinch]

@franticticktick Thanks for the pull request. This is now merged into master along with a841737 to fix the generic types.

NOTE: This can also be fixed using ResolvableType.forClassWithGenerics(AuthenticationExtensionsClientInput.class, Boolean.class).resolve()