Encode clientId and clientSecret for OpaqueTokenIntrospector and ReactiveOpaqueTokenIntrospector
#16008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
jzheaux
added
status: blocked
jzheaux
requested changes
Dec 19, 2024
There was a problem hiding this comment.
@ngocnhan-tran1996 thanks for your patience while we got ready for 6.5 development. I've left my feedback inline.
...ngframework/security/oauth2/server/resource/introspection/NimbusOpaqueTokenIntrospector.java
Outdated
Show resolved
Hide resolved
...ngframework/security/oauth2/server/resource/introspection/SpringOpaqueTokenIntrospector.java
Outdated
Show resolved
Hide resolved
ngocnhan-tran1996
force-pushed
the
encode-client-before-calling-basic-auth
branch
3 times, most recently
from
9a239bc to
c1f2f7d
Compare
jzheaux
requested changes
Dec 19, 2024
There was a problem hiding this comment.
Thanks, @ngocnhan-tran1996! I've sent you some of my feedback, mostly about Security's code conventions. Also, if you are able, please also update the documentation to use the builder instead of the now-deprecated constructor.
...ngframework/security/oauth2/server/resource/introspection/SpringOpaqueTokenIntrospector.java
Outdated
Show resolved
Hide resolved
...ngframework/security/oauth2/server/resource/introspection/SpringOpaqueTokenIntrospector.java
Outdated
Show resolved
Hide resolved
...ngframework/security/oauth2/server/resource/introspection/SpringOpaqueTokenIntrospector.java
Outdated
Show resolved
Hide resolved
...ngframework/security/oauth2/server/resource/introspection/SpringOpaqueTokenIntrospector.java
Outdated
Show resolved
Hide resolved
...ngframework/security/oauth2/server/resource/introspection/SpringOpaqueTokenIntrospector.java
Outdated
Show resolved
Hide resolved
...ngframework/security/oauth2/server/resource/introspection/SpringOpaqueTokenIntrospector.java
Outdated
Show resolved
Hide resolved
ngocnhan-tran1996
force-pushed
the
encode-client-before-calling-basic-auth
branch
from
b55d6be to
116b041
Compare
jzheaux
requested changes
Jan 14, 2025
There was a problem hiding this comment.
Thanks for the update, @ngocnhan-tran1996, and for your patience as I came back around to this PR. I've left some additional feedback inline.
Also, are you able to update the documentation here and here to use the new builder instead of the now-deprecated constructor?
...ngframework/security/oauth2/server/resource/introspection/SpringOpaqueTokenIntrospector.java
Show resolved
Hide resolved
...ngframework/security/oauth2/server/resource/introspection/SpringOpaqueTokenIntrospector.java
Outdated
Show resolved
Hide resolved
...ngframework/security/oauth2/server/resource/introspection/SpringOpaqueTokenIntrospector.java
Outdated
Show resolved
Hide resolved
...ecurity/oauth2/server/resource/introspection/SpringReactiveOpaqueTokenIntrospectorTests.java
Outdated
Show resolved
Hide resolved
ngocnhan-tran1996
force-pushed
the
encode-client-before-calling-basic-auth
branch
2 times, most recently
from
bda3381 to
14e71ef
Compare
Closes spring-projectsgh-15988 Signed-off-by: Tran Ngoc Nhan <ngocnhan.tran1996@gmail.com>
jzheaux
force-pushed
the
encode-client-before-calling-basic-auth
branch
from
3a1bc56 to
cfa1dda
Compare
jzheaux
approved these changes
Jan 16, 2025
jzheaux
removed
the
status: blocked
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes gh-15988