Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mention all required dependencies in LDAP documentation #15235

Closed
wants to merge 1 commit into from

Conversation

Harsh4902
Copy link
Contributor

@pivotal-cla
Copy link

@Harsh4902 Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@pivotal-cla
Copy link

@Harsh4902 Thank you for signing the Contributor License Agreement!

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jun 12, 2024
sjohnr added a commit that referenced this pull request Jun 13, 2024
@sjohnr
Copy link
Member

sjohnr commented Jun 13, 2024

Thanks @Harsh4902, this is merged as 92cab2b with polish commit f622d8e. I adjusted the wording to mention Spring Boot and fixed the build failure with attributes by removing the versions which aren't needed here.

@sjohnr sjohnr closed this Jun 13, 2024
@sjohnr sjohnr self-assigned this Jun 13, 2024
@sjohnr sjohnr added in: docs An issue in Documentation or samples type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Jun 13, 2024
@sjohnr sjohnr added this to the 5.8.13 milestone Jun 13, 2024
@Harsh4902
Copy link
Contributor Author

@sjohnr Thank you for helping, and sorry for the issue of that version attribute.

@sjohnr
Copy link
Member

sjohnr commented Jun 14, 2024

Not a problem @Harsh4902. Thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: docs An issue in Documentation or samples type: enhancement A general enhancement
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants