Allow JWT issuer AuthenticationManagerResolvers to accept predicate issuer validator #13428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
singhbaljit
force-pushed
the
predicate-issuer-resolver
branch
from
bd0ba03 to
633a2c2
Compare
jzheaux
added
type: enhancement
jzheaux
requested changes
Jul 12, 2023
There was a problem hiding this comment.
Thanks, @singhbaljit! First, please see my inline feedback.
Second, will you please add some tests of the new functionality?
...k/security/oauth2/server/resource/authentication/JwtIssuerAuthenticationManagerResolver.java
Outdated
Show resolved
Hide resolved
...k/security/oauth2/server/resource/authentication/JwtIssuerAuthenticationManagerResolver.java
Show resolved
Hide resolved
...k/security/oauth2/server/resource/authentication/JwtIssuerAuthenticationManagerResolver.java
Outdated
Show resolved
Hide resolved
...k/security/oauth2/server/resource/authentication/JwtIssuerAuthenticationManagerResolver.java
Outdated
Show resolved
Hide resolved
singhbaljit
force-pushed
the
predicate-issuer-resolver
branch
from
633a2c2 to
3d6f918
Compare
re: testsI'm honestly not sure what new tests to add. The existing tests already cover the functionality. I'm just exposing it publicly. |
singhbaljit
force-pushed
the
predicate-issuer-resolver
branch
2 times, most recently
from
828e780 to
1c04dbb
Compare
jzheaux
force-pushed
the
predicate-issuer-resolver
branch
from
1c04dbb to
b63ac11
Compare
jzheaux
approved these changes
Aug 7, 2023
jzheaux
force-pushed
the
predicate-issuer-resolver
branch
2 times, most recently
from
cdce2ab to
5695abe
Compare
singhbaljit
commented
Aug 7, 2023
...k/security/oauth2/server/resource/authentication/JwtIssuerAuthenticationManagerResolver.java
Outdated
Show resolved
Hide resolved
jzheaux
force-pushed
the
predicate-issuer-resolver
branch
from
5695abe to
c285716
Compare
- Added JavaDoc @SInCE attribute - Added Predicate based test - Adjusted test names Issue spring-projectsgh-13427
jzheaux
force-pushed
the
predicate-issuer-resolver
branch
from
c285716 to
b77f65b
Compare
|
Also, you probably want to fixup the |
|
Thanks, @singhbaljit! This is now merged into |
|
Also, the documentation was updated in 3b7e7f6 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #13427
TrustedIssuerJwtAuthenticationManagerResolverpublic so constructors to validate issuer with a predicate can be used.Setinstead ofArrayList; it has O(1) time complexity for look ups.