Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use MvcRequestMatcher by default if Spring MVC is present #11950

Merged
merged 1 commit into from
Oct 6, 2022
Merged

Use MvcRequestMatcher by default if Spring MVC is present #11950

merged 1 commit into from
Oct 6, 2022

Conversation

marcusdacoregio
Copy link
Contributor

Closes gh-11899

@marcusdacoregio marcusdacoregio added status: duplicate A duplicate of another issue in: config An issue in spring-security-config type: enhancement A general enhancement type: breaks-passivity A change that breaks passivity with the previous release labels Oct 4, 2022
@marcusdacoregio marcusdacoregio added this to the 6.0.0-RC1 milestone Oct 4, 2022
@marcusdacoregio marcusdacoregio self-assigned this Oct 4, 2022
@rwinch rwinch self-assigned this Oct 4, 2022
@rwinch rwinch self-requested a review October 4, 2022 17:38
rwinch
rwinch requested changes Oct 4, 2022
View reviewed changes
Copy link
Member

@rwinch rwinch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had one comment around a file that doesn't look like it needs to change. Other than that, it appears to look good to me.

...ork/security/config/http/OAuth2ResourceServerBeanDefinitionParserTests-JwtRestOperations.xml Outdated
@@ -1,12 +1,12 @@
<?xml version="1.0" encoding="UTF-8"?>
<!--
~ Copyright 2002-2020 the original author or authors.
~ Copyright 2002-2022 the original author or authors.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file doesn't seem to need to be changed.

@marcusdacoregio
Copy link
Contributor Author

Thanks @rwinch, I've updated the PR.

@marcusdacoregio marcusdacoregio merged commit c4d23f2 into spring-projects:main Oct 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rwinch rwinch rwinch approved these changes

Assignees

@rwinch rwinch

@marcusdacoregio marcusdacoregio

Labels
in: config An issue in spring-security-config status: duplicate A duplicate of another issue type: breaks-passivity A change that breaks passivity with the previous release type: enhancement A general enhancement
Projects
None yet
Milestone
6.0.0-RC1
Development

Successfully merging this pull request may close these issues.

Use MvcRequestMatcher by default if Spring MVC is present
2 participants
@marcusdacoregio @rwinch