Skip to content

Add RequestMatcher.matcher(HttpServletRequest) #7148

Closed
@rwinch

Description

@rwinch

Summary

Anyone wanting to take this on can request to take the whole thing on or just one step (but it must be the first step that has not been completed).

Step 1

We should add a default method to RequestMatcher that looks like this:

default MatchResult matcher(HttpServletRequest request) {
	boolean match = matches(request);
    return new MatchResult(match);
}

The MatchResult should look similar to ServerWebExchangeMatcher.MatchResult except it uses servlet request and non-reactive types.

Step 2

Then implementations of RequestVariablesExtractor should be updated to implement the matcher method and RequestVariablesExtractor should be deprecated.

Step 3

Usage of RequestVariablesExtractor or types that are assigned to AntPathRequestMatcher should be replaced with the new method.

Metadata

Metadata

Assignees

No one assigned

    Labels

    in: webAn issue in web modules (web, webmvc)status: ideal-for-contributionAn issue that we actively are looking for someone to help us withtype: enhancementA general enhancement

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions