Skip to content

Fix for #15172 introduces significant performance degredation #15324

Closed
@Mnkras

Description

@Mnkras

Describe the bug
In commit 7288fec the assertion on the input to check if the input was a valid ip was "fixed" to make it more complete, unfortunately the additional checks significantly increase CPU time which was unexpected.

It seems that the new assertions are more computationally expensive than the actual matching code.

To Reproduce
Run sample below for a basic test showing the difference is performance

Expected behavior
No significant performance regressions

Sample

(https://gist.github.com/Mnkras/b02bd4e68cc4455d1aed6b2dde8c411f)

@jzheaux FYI

Metadata

Metadata

Assignees

Labels

in: webAn issue in web modules (web, webmvc)type: bugA general bug

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions