Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

relying-party-registration doesn't allow placeholders in xml #14645

Open
abhishek-bafna-amdhan opened this issue Feb 22, 2024 · 1 comment
Open
Assignees
Labels
in: saml2 An issue in SAML2 modules type: enhancement A general enhancement
Milestone

Comments

@abhishek-bafna-amdhan
Copy link

Using Spring Security 6.0.8

I use XML based configuration for most security setup as I have customisations that need to be dynamically processed.

Using <security:relying-party-registration... Everything works fine if I hardcode the metadata-location and assertion-consumer-service-location but using a propertyConfigurer the values aren't used.

I have this setup for the propertyConfigurer

<context:property-placeholder location="file:${application.properties}"/>

application.properties contains these values:

relying-party-registration.metadata-location=*****
relying-party-registration.assertion-location=*****
relying-party-registration.logout-location=*****

relying-party-registrations is setup like this:

<security:relying-party-registrations>
        <security:relying-party-registration registration-id="example123"
                                             metadata-location="${relying-party-registration.metadata-location}"
                                             single-logout-service-location="${relying-party-registration.logout-location}"
                                             entity-id="some:entity:id"
                                             assertion-consumer-service-location="${relying-party-registration.assertion-location}">
        </security:relying-party-registration>
</security:relying-party-registrations>

Values are not propagated in the relying-party-registration.

@dcdinesh1
Copy link

I am also facing the same issue, upgrade of spring security work is stuck because of it.

@jzheaux jzheaux added this to the 6.3.0 milestone Apr 15, 2024
@jzheaux jzheaux added in: saml2 An issue in SAML2 modules and removed status: waiting-for-triage An issue we've not yet triaged labels Apr 15, 2024
@jzheaux jzheaux self-assigned this Apr 15, 2024
@marcusdacoregio marcusdacoregio modified the milestones: 6.3.0, 6.4.0-M1 May 20, 2024
@marcusdacoregio marcusdacoregio modified the milestones: 6.4.0-M1, 6.4.0-M2 Jul 15, 2024
@sjohnr sjohnr modified the milestones: 6.4.0-M2, 6.4.0-M3 Aug 19, 2024
@marcusdacoregio marcusdacoregio modified the milestones: 6.4.0-M3, 6.4.0-M4 Aug 22, 2024
@jzheaux jzheaux modified the milestones: 6.4.0-M4, 6.4.0-RC1 Sep 16, 2024
@jzheaux jzheaux added type: enhancement A general enhancement and removed type: bug A general bug labels Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: saml2 An issue in SAML2 modules type: enhancement A general enhancement
Projects
Status: No status
Development

No branches or pull requests

5 participants