Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default RequestMatchers for Saml2WebSsoAuthenticationFilter and OpenSamlAuthenticationTokenConverter should align #13653

Closed
jzheaux opened this issue Aug 16, 2023 · 1 comment
Closed

Default RequestMatchers for Saml2WebSsoAuthenticationFilter and OpenSamlAuthenticationTokenConverter should align #13653

jzheaux opened this issue Aug 16, 2023 · 1 comment
Assignees
@jzheaux
Labels
in: saml2 An issue in SAML2 modules type: enhancement A general enhancement
Milestone
6.2.0-M2

Comments

@jzheaux
Copy link
Contributor

jzheaux commented Aug 16, 2023

Given that OpenSamlAuthenticationTokenConverter is the default authentication converter used by spring-security-config when constructing a Saml2WebSsoAuthenticationFilter, it's a bit odd that the authentication converter matches more endpoints than the filter that uses it.

For backward compatibility, this should be isolated to a new constructor Saml2WebSsoAuthenticationFilter(AuthenticationConverter).
@jzheaux jzheaux added type: enhancement A general enhancement in: saml2 An issue in SAML2 modules labels Aug 16, 2023
@jzheaux jzheaux added this to the 6.2.0-M2 milestone Aug 16, 2023
@jzheaux jzheaux self-assigned this Aug 16, 2023
jzheaux added a commit that referenced this issue Aug 16, 2023
@jzheaux
Add CSRF Exception
3ba5cc0 
Issue gh-13653
@jzheaux
Copy link
Contributor Author

jzheaux commented Aug 16, 2023

Closed in 3ba5cc0

@jzheaux jzheaux closed this as completed Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jzheaux jzheaux

Labels
in: saml2 An issue in SAML2 modules type: enhancement A general enhancement
Projects
None yet
Milestone
6.2.0-M2
Development

No branches or pull requests
1 participant
@jzheaux