Improve RequestMatcher Validation

[jzheaux]

[albertus82]

Hi, just updated from 5.8.4 to 5.8.5 and encountered java.lang.IllegalArgumentException: This method cannot decide whether these patterns are Spring MVC patterns or not. at application startup. I'm surprised because this is only a patch update.

[kzander91]

For me, this happens when running locally with spring-boot-devtools, which automatically enables the H2 console. At runtime, this causes two servlets to be registered which for some reason confuses Spring Security.
I don't need the H2 console, so spring.h2.console.enabled=false is my workaround for now.

[bartolom]

We have a non-Spring-Boot, "traditional" Spring Framework 5.3.29 MVC application which is deployed into a Tomcat 9

The upgrade from 5.8.4 to 5.8.5 also produces java.lang.IllegalArgumentException: This method cannot decide whether these patterns are Spring MVC patterns or not. at application startup.

We follow pretty much the "A 100% code-based approach to configuration" pattern as described here https://docs.spring.io/spring-framework/docs/5.3.x/javadoc-api/org/springframework/web/WebApplicationInitializer.html

But a stand alone Tomcat in its default configuration creates two more Servlets named "default" and "jsp"

https://tomcat.apache.org/tomcat-9.0-doc/default-servlet.html

Therefore registrations.size() is 3 in our case.

We want to avoid that our operations team has to alter the default Tomcat web.xml each time they upgrade Tomcat.

Do we need to migrate to the mentioned requestMatchers(MvcRequestMatcher) ?

[albertus82]

@bartolom I think you should open a new issue. This one is closed and I'm noticing it's not getting any attention.