Document what is the difference between new requestMatchers and securityMatchers

[craph]

Expected Behavior

Is it possible to have a more detailled documentation about the difference betwenn new requestMatchers and securityMatchers ?

Current Behavior

After reading this : https://docs.spring.io/spring-security/reference/5.8/migration/servlet/config.html#use-new-security-matchers

there is :

In Spring Security 5.8, the antMatchers, mvcMatchers, and regexMatchers methods were deprecated in favor of new requestMatchers methods.

and

In Spring Security 5.8, the antMatchers, mvcMatchers and requestMatchers methods from HttpSecurity were deprecated in favor of new securityMatchers methods.

It's a little confusing.

Is there any documentation that explains the difference with examples and may be samples with an equivalent with xml configuration to have another view ?

By reading the current documentation, I don't understand when to use securityMatchers

How securityMatchers is different from requestMatchers ?

Context

Thank you very much for your help.
Best regards,

[pnedonosko]

+1 to the question: the new securityMatcher/securityMatchers methods create confusion when read the doc. It's not obvious when to use what: securityMatcher or authorizeHttpRequests or both, what effects in the result? Especially knowing the authorizeHttpRequests is a new thing instead of deprecated authorizeRequests, when a newbie look at the sample from 6.0.3 doc (and many examples in internet but for older versions), use of the the both with comments below may mislead seriously:

@Bean
	public SecurityFilterChain securityFilterChain(HttpSecurity http) throws Exception {
		http
			.securityMatcher("/api/**")                            <<< 1
			.authorizeHttpRequests(authorize -> authorize
				.requestMatchers("/user/**").hasRole("USER")       <<< 2
				.requestMatchers("/admin/**").hasRole("ADMIN")     <<< 3
				.anyRequest().authenticated()                      
			)
			.formLogin(withDefaults());
		return http.build();
	}

1. Configure HttpSecurity to only be applied to URLs that start with /api/
2. Allow access to URLs that start with /user/ to users with the USER role
3. Allow access to URLs that start with /admin/ to users with the ADMIN role

After finding similar code samples with roles/authorities but without securityMatcher used, it messes things and creates more questions instead of understanding. For sure such answers can be found in the Spring Security code, but it's not a quick way and often shifts the focus.

But would the sample code be like:

      .securityMatcher("/api/**")
      .authorizeHttpRequests(authorize -> authorize
				.requestMatchers("/api/user/**").hasRole("USER")       
				.requestMatchers("/api/admin/**").hasRole("ADMIN")     
				.anyRequest().authenticated()                      
			)

with later description something like:
Configure HttpSecurity for only URLs starting with /api and next customizing authorized access for /api/user to only USER and /api/admin to ADMIN roles, we leave all other URLs not secured (without authentication and authorization).
Note, that several URL patterns can be supplied to securityMatcher for applying security on all them.

Thank you.

[ghusta]

A good example on how to use the new securityMatcher(...) can be found in this video by Dan Vega 👍

🎬 https://www.youtube.com/watch?v=PczgM2L3w60

See also : https://docs.spring.io/spring-security/reference/5.8/servlet/configuration/java.html#_multiple_httpsecurity

[pnedonosko]

@ghusta a good example, thank you Guillaume 👍

[ASDasd341]

1. request Matchers is a method provided by the Http Security class in Spring Security. It is used to match incoming requests based on URL patterns and HTTP methods. it is typically used in the configure(Http Security http) method of a custom "WebSecurityConfigurerAdapter.requestMatchers" method accepts one or more Request Matcher instances, which determine which requests should be matched by the security rules. A Request Matcher can be created using AntPathRequestMatcher.

2.  protected void configure(Http Security http) throws Exception {
     http
    .authorizeRequests()
        .requestMatchers(new AntPathRequestMatcher("/public/**")).permitAll()
        .requestMatchers(new RegexRequestMatcher("/admin/.*", "GET")).hasRole("ADMIN")
        .anyRequest().authenticated()
    .and()
    .formLogin()
    .and()
    .httpBasic();
   

}
3. securityMatchers is a method provided by the RequestMatcherConfigurer class in Spring Security. It is used in combination with antMatchers, regexMatchers, and other similar methods to configure URL pattern matching for security rules. securityMatchers method accepts one or more RequestMatcher instances along with an additional RequestMatcher for the condition.
protected void configure(HttpSecurity http) throws Exception {
http
.authorizeRequests()
.securityMatchers(new AntPathRequestMatcher("/api/**"),
new HeadersRequestMatcher("X-Requested-With", "XMLHttpRequest")).authenticated()
.anyRequest().permitAll()
.and()
.formLogin()
.and()
.httpBasic();
}

[onomesotu]

This part of the document describes the usages and differences quite clearly:
https://docs.spring.io/spring-security/reference/5.8/servlet/authorization/authorize-http-requests.html#_request_matchers

[sjohnr]

@pnedonosko

But would the sample code be like:

      .securityMatcher("/api/**")
      .authorizeHttpRequests(authorize -> authorize
				.requestMatchers("/api/user/**").hasRole("USER")       
				.requestMatchers("/api/admin/**").hasRole("ADMIN")     
				.anyRequest().authenticated()                      
			)

I think you are correct that this is a typo in the docs and it should be as you corrected it to be. Would you mind opening a new issue or pull request to correct the example here?

---

@craph @pnedonosko @ghusta @onomesotu @ASDasd341 thanks so much for the feedback!

In addition to this answer:

This part of the document describes the usages and differences quite clearly: https://docs.spring.io/spring-security/reference/5.8/servlet/authorization/authorize-http-requests.html#_request_matchers

I've also recently enhanced the Configuration > Java and Configuration > Kotlin chapters of the reference.

Regarding "What is the difference between new requestMatchers and securityMatchers?" based on the opening comment:

By reading the current documentation, I don't understand when to use securityMatchers

I feel like the docs update now answers this question in the section Choosing securityMatcher or requestMatchers. As such, I'm going to close this issue as a duplicate of gh-14419 just for book-keeping since that issue is already resolved.

If anyone has additional feedback please don't hesitate to comment here or open a new issue and we can keep improving the docs!

[dsuepke-swisscom]

Hello, I would like to point out that even with the new documentation the difference between requestMatchers and securityMatchers is still completely lost on me (and others). I googled for this and all I found were questions from others what the difference is with no answers, since apparently (almost) no one seems to understand.

This notion - imho - is very much untrue:

This part of the document describes the usages and differences quite clearly: https://docs.spring.io/spring-security/reference/5.8/servlet/authorization/authorize-http-requests.html#_request_matchers

[sjohnr]

@dsuepke-swisscom thank you so much for your feedback! I am sorry you still do not have a good grasp on this concept. We are actively taking in feedback such as this and working hard on ways to improve Spring Security and make it easier for everyone. We don't yet know what that will look like, but please know that it is a priority. In the meantime, is there anything specific you feel can be done to help improve the situation?

I've also recently enhanced the Configuration > Java and Configuration > Kotlin chapters of the reference.

I've tried to outline a set of examples in the above links for 6.4 (starting from Multiple HttpSecurity Instances) that demonstrate the difference. Can you help me improve them?