Skip to content

GH-427: Add fix for the issue with multiplierExpression and randomExp… #428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
May 10, 2024
Merged

GH-427: Add fix for the issue with multiplierExpression and randomExp… #428

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
1e94041
GH-427: Add fix for the issue with multiplierExpression and randomExp…
aftabshk Apr 27, 2024
7c478d1
GH-427: Fix issue with multiplierExpression between 0 to 1
aftabshk May 3, 2024
471de0b
GH-427: Fix randomExpression javadoc
aftabshk May 3, 2024
03e3794
Revert "GH-427: Fix issue with multiplierExpression between 0 to 1"
aftabshk May 3, 2024
a814391
GH-427: Evaluate multiplierSupplier only at runtime
aftabshk May 3, 2024
f4df7c2
GH-427: Use parsedMultExp instead of multiplierExpression
aftabshk May 9, 2024
70b1e1b
GH-427: Fix unit tests and documentation
aftabshk May 10, 2024
3671ae1
GH-427: Refactor tests
aftabshk May 10, 2024
41b3530
GH-427: Add unit tests
aftabshk May 10, 2024
2b8feb7
GH-427: Fix indentation
aftabshk May 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
GH-427: Refactor tests
  • Loading branch information
@aftabshk
aftabshk committed May 10, 2024
commit 3671ae14c9b23cb34a80e730ea8518cf92efbdd3
3 changes: 0 additions & 3 deletions src/test/java/org/springframework/retry/backoff/BackOffPolicyBuilderTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,6 @@ public void shouldCreateExponentialRandomBackOffWhenProvidedRandomSupplier() {
assertThat(policy.getInitialInterval()).isEqualTo(10000);
assertThat(policy.getMaxInterval()).isEqualTo(100000);
assertThat(policy.getMultiplier()).isEqualTo(10);
assertThat(new DirectFieldAccessor(policy).getPropertyValue("sleeper")).isEqualTo(mockSleeper);
}

@Test
Expand All @@ -145,7 +144,6 @@ public void shouldCreateExponentialRandomBackOffWithProvidedSuppliers() {
assertThat(policy.getInitialInterval()).isEqualTo(10000);
assertThat(policy.getMaxInterval()).isEqualTo(100000);
assertThat(policy.getMultiplier()).isEqualTo(10);
assertThat(new DirectFieldAccessor(policy).getPropertyValue("sleeper")).isEqualTo(mockSleeper);
}

@Test
Expand All @@ -163,7 +161,6 @@ public void shouldCreateExponentialBackOffWhenProvidedRandomSupplier() {
assertThat(policy.getInitialInterval()).isEqualTo(100);
assertThat(policy.getMaxInterval()).isEqualTo(1000);
assertThat(policy.getMultiplier()).isEqualTo(2);
assertThat(new DirectFieldAccessor(policy).getPropertyValue("sleeper")).isEqualTo(mockSleeper);
}

}